Chromium_android.py contains hard-coded skipped directories in ChromiumAndroidPort.skipped_layout_tests(). This looks not good, and new-run-webkit-tests --lint will report many errors. Investigate how to remove them. Putting them in TestExpectations is a choice but needs to exclude ANDROID from existing rules of the individual tests under these directories.
using the separate expectations file as suggested in the other bug solves this problem as well ... skipping the whole directory in the later file should override individual tests in the earlier file.
(In reply to comment #1) > using the separate expectations file as suggested in the other bug solves this problem as well ... skipping the whole directory in the later file should override individual tests in the earlier file. Oh, I should have remembered this. This was just the way worked in downstream but I just thought it weren't work :)
Created attachment 161779 [details] Patch
Comment on attachment 161779 [details] Patch I would put the file in platform/chromium-android/TestExpectations and leave out the "ANDROID" modifiers to be more consistent with the other ports.
Comment on attachment 161779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161779&action=review > LayoutTests/platform/chromium/TestExpectationsAndroid:38 > +BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/time-multiple-fields = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/color = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/datalist = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/forms/date = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/mediastream = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/notifications = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : fast/speech = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : http/tests/notifications = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : platform/chromium/fast/forms/color = PASS > +BUGCR145338 WONTFIX ANDROID SKIP : webaudio = PASS Drive by comment unrelated to this patch. Do we really never intend to implement these on android?
Created attachment 161798 [details] Patch
Comment on attachment 161779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161779&action=review >> LayoutTests/platform/chromium/TestExpectationsAndroid:38 >> +BUGCR145338 WONTFIX ANDROID SKIP : webaudio = PASS > > Drive by comment unrelated to this patch. Do we really never intend to implement these on android? Not sure for the unlimited future :) Removed the WONTFIX to keep consistent with the status of the bug.
(In reply to comment #4) > (From update of attachment 161779 [details]) > I would put the file in platform/chromium-android/TestExpectations and leave out the "ANDROID" modifiers to be more consistent with the other ports. Done. I also moved other skipping rules into platform/chromium-android/TestExpectations because they will have a better context there. For example, it seems better to put together the rules for plugins directories and plugin tests out of the plugin directories.
Created attachment 161831 [details] Rebased
Comment on attachment 161831 [details] Rebased Rejecting attachment 161831 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: erge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests) When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13724609
Created attachment 161832 [details] Rebased again
Comment on attachment 161832 [details] Rebased again Clearing flags on attachment: 161832 Committed r127382: <http://trac.webkit.org/changeset/127382>
All reviewed patches have been landed. Closing bug.
This is also a part of Android test expectation upstreaming.