[chromium] Add main versus impl thread asserts
Created attachment 161745 [details] Patch
PTAL, this is a subset of bug 95057 (since that was getting unwieldy).
Comment on attachment 161745 [details] Patch R=me
Comment on attachment 161745 [details] Patch Rejecting attachment 161745 [details] from commit-queue. ccameron@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 161745 [details] Patch You can set CQ? but not CQ+ until you're a committer, as the bot has said :)
Comment on attachment 161745 [details] Patch Rejecting attachment 161745 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13720300
Second time I've seen that happen for now even though it has R+. Must be a bug in the bot. :\
Comment on attachment 161745 [details] Patch it's not a bug in the bot, WebCore/ChangeLog doesn't have a "Reviewed by NOBODY (OOPS!)." line in it. Add it back and the queue will accept it
Created attachment 161759 [details] Patch
Ah, thanks. Fixed.
Comment on attachment 161759 [details] Patch Clearing flags on attachment: 161759 Committed r127317: <http://trac.webkit.org/changeset/127317>
All reviewed patches have been landed. Closing bug.