Bug 95382 – Remove ENABLE_CSS3_FLEXBOX compile time flag

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Remove ENABLE_CSS3_FLEXBOX compile time flag

[Tony Chang]

Created attachment 161321 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 161321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161321&action=review

> Source/cmakeconfig.h.cmake:-27
> -#cmakedefine01 ENABLE_CSS3_FLEXBOX

Can you also remove the entry in Source/cmake/WebKitFeatures.cmake?

[Tony Chang]

Created attachment 161343 [details]
Patch

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 161321 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161321&action=review
> 
> > Source/cmakeconfig.h.cmake:-27
> > -#cmakedefine01 ENABLE_CSS3_FLEXBOX
> 
> Can you also remove the entry in Source/cmake/WebKitFeatures.cmake?

Oops, sorry for missing it.

Note that this was announced on webkit-dev: http://lists.webkit.org/pipermail/webkit-dev/2012-August/021965.html

[Early Warning System Bot]

Comment on attachment 161343 [details]
Patch

Attachment 161343 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13689448

[Tony Chang]

The qt-wk2 failure seems unrelated and the previous patch passed on the same bot.

I think we can review this patch now.

[Csaba Osztrogonác]

(In reply to comment #6)
> The qt-wk2 failure seems unrelated and the previous patch passed on the same bot.
> 
> I think we can review this patch now.

Yes this build fail is unrelated, this flakiness tracked by -https://bugs.webkit.org/show_bug.cgi?id=93847

[Tony Chang]

Committed r127318: <http://trac.webkit.org/changeset/127318>