Bug 95297 - [EFL] EFL port should turn on ENCRYPTED_MEDIA
Summary: [EFL] EFL port should turn on ENCRYPTED_MEDIA
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 23:56 PDT by Chris Dumez
Modified: 2017-03-11 10:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2014-10-22 04:57 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-08-28 23:56:06 PDT 
EFL port does not current enable ENCRYPTED_MEDIA.

It is covered by:
media/encrypted-media/
fast/events/constructors/media-key-event-constructor.html
Comment 1 Éva Balázsfalvi 2014-10-22 04:57:05 PDT 
Created attachment 240266 [details]
Patch
Comment 2 Gyuyoung Kim 2014-10-22 08:11:02 PDT 
Comment on attachment 240266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240266&action=review

> LayoutTests/platform/efl/TestExpectations:1119
> +# These tests are for an obsolete version of the EME spec.

I think you have to place these failing tests in  TESTS EXPECTED TO FAIL area. Here is for tests which needs to be investigated.
Comment 3 Csaba Osztrogonác 2014-10-22 09:51:29 PDT 
Comment on attachment 240266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240266&action=review

> LayoutTests/platform/efl/TestExpectations:1117
> +webkit.org/b/95297 media/encrypted-media [ Pass ]
> +webkit.org/b/95297 fast/events/constructors/media-key-event-constructor.html [ Pass ]

Please remove these lines instead of marking them as [ Pass ].

>> LayoutTests/platform/efl/TestExpectations:1119
>> +# These tests are for an obsolete version of the EME spec.
> 
> I think you have to place these failing tests in  TESTS EXPECTED TO FAIL area. Here is for tests which needs to be investigated.

Agree.
Comment 4 Philippe Normand 2014-10-23 00:22:20 PDT 
What's the point of enabling this non-working feature?
Comment 5 Éva Balázsfalvi 2014-10-28 08:39:34 PDT 
I accidentally turned on ENCRYPTED_MEDIA in OptionsEfl.cmake, didn't mean to leave it in the code.

I only wanted to unskip the passing ENCRYPTED_MEDIA_V2 tests after r170910.

Since my patch is not really doing what is requested in this bug report, I created a new, more fitting bug report for it: https://bugs.webkit.org/show_bug.cgi?id=138133
Comment 6 Michael Catanzaro 2017-03-11 10:41:11 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.