Bug 138133 - [EFL] Unskip passing ENCRYPTED_MEDIA_V2 tests
Summary: [EFL] Unskip passing ENCRYPTED_MEDIA_V2 tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Éva Balázsfalvi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 07:53 PDT by Éva Balázsfalvi
Modified: 2014-11-03 07:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.16 KB, patch)
2014-10-28 08:21 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2014-11-03 05:15 PST, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Patch for landing (2.23 KB, patch)
2014-11-03 07:02 PST, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-10-28 07:53:05 PDT 
We should unskip now passing ENCRYPTED_MEDIA_V2 tests on EFL.
Comment 1 Éva Balázsfalvi 2014-10-28 08:21:12 PDT 
Created attachment 240540 [details]
Patch
Comment 2 Éva Balázsfalvi 2014-10-28 09:36:46 PDT 
> LayoutTests/platform/efl/TestExpectations:1125
> +webkit.org/b/95297 media/encrypted-media [ Pass ]
> +webkit.org/b/95297 fast/events/constructors/media-key-event-constructor.html [ Pass ]

Marking these lines "Pass" instead of deleting them, because of

LayoutTests/platform/efl/TestExpectations:496
webkit.org/b/131044 media [ Skip ]

Removing the lines above would cause the ENCRYPTED_MEDIA_V2 related tests to skip because of this line.
Comment 3 Éva Balázsfalvi 2014-11-03 05:15:36 PST 
Created attachment 240841 [details]
Patch
Comment 4 Csaba Osztrogonác 2014-11-03 06:03:23 PST 
Comment on attachment 240841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240841&action=review

LGTM, but please fix the style before landing.

> LayoutTests/platform/efl/TestExpectations:1127
> +webkit.org/b/95297 media/encrypted-media [ Pass ]
> +
> +# Failing, need to fix. https://bugs.webkit.org/show_bug.cgi?id=138307
> +media/encrypted-media/encrypted-media-can-play-type.html [ Skip ]

webkit.org/b/138307 media/encrypted-media/encrypted-media-can-play-type.html [ Skip ]
Comment 5 Éva Balázsfalvi 2014-11-03 07:02:34 PST 
Created attachment 240849 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-11-03 07:47:04 PST 
Comment on attachment 240849 [details]
Patch for landing

Clearing flags on attachment: 240849

Committed r175470: <http://trac.webkit.org/changeset/175470>
Comment 7 WebKit Commit Bot 2014-11-03 07:47:07 PST 
All reviewed patches have been landed.  Closing bug.