Bug 95275 - [Chromium] Update some compositor trace events
Summary: [Chromium] Update some compositor trace events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 18:16 PDT by John Bates
Modified: 2012-08-28 20:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2012-08-28 18:16 PDT, John Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bates 2012-08-28 18:16:08 PDT 
[Chromium] Update some compositor trace events
Comment 1 John Bates 2012-08-28 18:16:40 PDT 
Created attachment 161107 [details]
Patch
Comment 2 John Bates 2012-08-28 18:17:08 PDT 
ptal
Comment 3 James Robinson 2012-08-28 18:21:16 PDT 
Comment on attachment 161107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161107&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:84
> -    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);
>      if (m_active == active)
>          return;
> +    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);

so is the thread code now working (https://bugs.webkit.org/show_bug.cgi?id=93918#c3) ?

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:331
> +    TRACE_EVENT2("cc", "CCThreadProxy::onVSyncParametersChanged", "monotonicTimebase", monotonicTimebase, "intervalInSeconds", intervalInSeconds);

Hm, the tracing code can take doubles? That's nice - but the type of the value parameter looks like unsigned long long to me. Do we need any casts?
Comment 4 John Bates 2012-08-28 19:02:47 PDT 
(In reply to comment #3)
> (From update of attachment 161107 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161107&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:84
> > -    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);
> >      if (m_active == active)
> >          return;
> > +    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);
> 
> so is the thread code now working (https://bugs.webkit.org/show_bug.cgi?id=93918#c3) ?

yeah, I found the issue a while ago.

> 
> > Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:331
> > +    TRACE_EVENT2("cc", "CCThreadProxy::onVSyncParametersChanged", "monotonicTimebase", monotonicTimebase, "intervalInSeconds", intervalInSeconds);
> 
> Hm, the tracing code can take doubles? That's nice - but the type of the value parameter looks like unsigned long long to me. Do we need any casts?

double should go through - the macros reinterpret it to/from unsigned long long.
Comment 5 James Robinson 2012-08-28 20:15:36 PDT 
Comment on attachment 161107 [details]
Patch

OK
Comment 6 WebKit Review Bot 2012-08-28 20:55:20 PDT 
Comment on attachment 161107 [details]
Patch

Clearing flags on attachment: 161107

Committed r126954: <http://trac.webkit.org/changeset/126954>
Comment 7 WebKit Review Bot 2012-08-28 20:55:23 PDT 
All reviewed patches have been landed.  Closing bug.