Bug 93918 - [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
Summary: [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 17:55 PDT by John Bates
Modified: 2012-08-13 19:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2012-08-13 17:56 PDT, John Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Bates 2012-08-13 17:55:32 PDT
[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
Comment 1 John Bates 2012-08-13 17:56:54 PDT
Created attachment 158173 [details]
Patch
Comment 2 James Robinson 2012-08-13 18:00:16 PDT
Comment on attachment 158173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81
> +    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);

This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets?
Comment 3 John Bates 2012-08-13 18:01:52 PDT
Comment on attachment 158173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81
>> +    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active);
> 
> This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets?

For debugging it's helpful to see. I will change it back once we've got the new thread code working.
Comment 4 James Robinson 2012-08-13 18:06:55 PDT
Comment on attachment 158173 [details]
Patch

OK
Comment 5 WebKit Review Bot 2012-08-13 19:54:13 PDT
Comment on attachment 158173 [details]
Patch

Clearing flags on attachment: 158173

Committed r125504: <http://trac.webkit.org/changeset/125504>
Comment 6 WebKit Review Bot 2012-08-13 19:54:16 PDT
All reviewed patches have been landed.  Closing bug.