RESOLVED FIXED 95189
[Chromium] Debug builds with ToT Chromium broken due to link failures for WebCompositor 
https://bugs.webkit.org/show_bug.cgi?id=95189
Summary [Chromium] Debug builds with ToT Chromium broken due to link failures for Web...
Peter Beverloo
Reported 2012-08-28 03:54:30 PDT
Sheriffs: FYI, as this blocks rolling WebKit. James: Please take a look. This started showing up on the canaries in the range Chromium [153477, 153638] and WebKit [126755, 126849]. Example build output here, and it also reproduces on Mac and Windows. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/10624/steps/compile/logs/stdio The relevant files were moved in WebKit r126813: http://trac.webkit.org/changeset/126813/trunk/Source/WebCore/WebCore.gypi The files are being compiled as part of the right target and removing the out/ directory does not help. Somehow the dependency is not being considered during linking. Release builds are working fine. Rolling Chromium r153640 into WebKit is fine for at least Linux and Android builds (and, according to the canaries, Mac and Windows too), but I'm hesitant on doing so as it will break all Chromium debug builds. This also blocks rolling WebKit into Chromium, as the same error will occur.
Attachments
Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-28 09:33:08 PDT
This doesn't make any sense to me. We can revert the .gypi change if we need to, it won't immediately explode too much else.
Peter Beverloo
Comment 2 2012-08-28 09:44:35 PDT
I tried to dig in to this some more, and was unable to find an obvious cause as well. Dependencies seem fine, files are in the right place and are being compiled, they're just not linked in. And it reproduces on all platforms.. Since this blocks rolls, I think we should roll this out for now and debug it locally.
James Robinson
Comment 3 2012-08-28 09:45:15 PDT
That sounds good to me.
Julien Chaffraix
Comment 4 2012-08-28 10:34:00 PDT
Change rolled out in http://trac.webkit.org/changeset/126890. Thanks Peter.
Peter Beverloo
Comment 5 2012-08-29 03:20:30 PDT
James is picking this up in Bug 94995. Marking as fixed as the compile works again.
Note You need to log in before you can comment on or make changes to this bug.