Bug 94995 - [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
Summary: [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 95211 95214
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-24 18:22 PDT by James Robinson
Modified: 2012-08-29 10:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2012-08-24 18:22 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2012-08-28 23:17 PDT, James Robinson 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-24 18:22:18 PDT 
[chromium] Put CCThreadImpl / WebCompositorImpl in webcore_chromium_compositor_files gyp section
Comment 1 James Robinson 2012-08-24 18:22:48 PDT 
Created attachment 160538 [details]
Patch
Comment 2 Adrienne Walker 2012-08-27 10:48:18 PDT 
Comment on attachment 160538 [details]
Patch

Should these files be moved too, for consistency? It looks like everything in platform/chromium/support goes into webcore_platform_support_files except for these.
Comment 3 James Robinson 2012-08-27 11:03:17 PDT 
Probably wouldn't hurt but wouldn't help too much either - they're getting nuked pretty soon.
Comment 4 Adrienne Walker 2012-08-27 13:12:06 PDT 
Comment on attachment 160538 [details]
Patch

R=me.  If they're just going to go away soon, then not moving them sounds reasonable.
Comment 5 WebKit Review Bot 2012-08-27 16:01:09 PDT 
Comment on attachment 160538 [details]
Patch

Clearing flags on attachment: 160538

Committed r126813: <http://trac.webkit.org/changeset/126813>
Comment 6 WebKit Review Bot 2012-08-27 16:01:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-08-28 09:47:35 PDT 
Re-opened since this is blocked by 95211
Comment 8 James Robinson 2012-08-28 12:27:26 PDT 
With use_libcc_for_compositor==0, I need to link WebCompositorImpl directly into the 'webkit' target along with the other webcore_platform_support_files.  Not sure how cr-linux is green on this.
Comment 9 James Robinson 2012-08-28 23:17:14 PDT 
Created attachment 161141 [details]
Patch
Comment 10 James Robinson 2012-08-28 23:17:44 PDT 
More direct - this just excludes those files from the 'webkit' target.  Trybots are much happier with this.
Comment 11 Adam Barth 2012-08-29 09:47:25 PDT 
Comment on attachment 161141 [details]
Patch

ok
Comment 12 James Robinson 2012-08-29 10:58:41 PDT 
Committed r127020: <http://trac.webkit.org/changeset/127020>