Bug 95014 – op_call should have ArrayProfiling for the benefit of array intrinsics

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 160574 [details]
the patch

[Filip Pizlo]

Created attachment 160576 [details]
the patch

Fixed some 32-bit goofs.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/126692

[Geoffrey Garen]

32bit Release Windows bot is crashing on every test. Started with <http://trac.webkit.org/changeset/126692>.

http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/26904
http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/26904/steps/layout-test/logs/stdio

[Geoffrey Garen]

FAULTING_SOURCE_CODE:  
   129: 
   130:         // Execute the code!
   131:         inline JSValue execute(RegisterFile* registerFile, CallFrame* callFrame, JSGlobalData* globalData)
   132:         {
>  133:             JSValue result = JSValue::decode(ctiTrampoline(m_ref.code().executableAddress(), registerFile, callFrame, 0, 0, globalData));
   134:             return globalData->exception ? jsNull() : result;
   135:         }
   136: 
   137:         void* start() const
   138:         {

JavaScriptCore!JSC::JITCode::execute+0x1f [c:\cygwin\home\buildbot\slave\win-release\build\source\javascriptcore\jit\jitcode.h JavaScriptCore!JSC::Interpreter::execute+0xfd4 [c:\cygwin\home\buildbot\slave\win-er\interpreter.cpp @ 1250]
JavaScriptCore!JSC::evaluate+0x132 [c:\cygwin\home\buildbot\slave\win-release\build\source\javascriptcore\runtime\completion.WebKit!WebCore::JSMainThreadExecState::evaluate+0x3b [c:\cygwin\home\buildbot\slave\win-inthreadexecstate.h @ 77]
WebKit!WebCore::ScriptController::evaluateInWorld+0xf7 [c:\cygwin\home\buildbot\slave\win-ptcontroller.cpp @ 149]
WebKit!WebCore::ScriptController::evaluate+0x44 [c:\cygwin\home\buildbot\slave\win-ptcontroller.cpp @ 165]
WebKit!WebCore::ScriptElement::executeScript+0x109 [c:\cygwin\home\buildbot\slave\win-t.cpp @ 301]
WebKit!WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent+0xc3 [c:\cygwin\home\buildbot\slave\win-scriptrunner.cpp @ 140]
WebKit!WebCore::HTMLScriptRunner::executeParsingBlockingScripts+0x7f [c:\cygwin\home\buildbot\slave\win-scriptrunner.cpp @ 190]
WebKit!WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad+0x5 [c:\cygwin\home\buildbot\slave\win-scriptrunner.cpp @ 200]
WebKit!WebCore::HTMLDocumentParser::notifyFinished+0x61 [c:\cygwin\home\buildbot\slave\win-documentparser.cpp @ 515]
WebKit!WebCore::CachedResource::checkNotify+0x3a [c:\cygwin\home\buildbot\slave\win-hedresource.cpp @ 248]
WebKit!WebCore::CachedScript::data+0x99 [c:\cygwin\home\buildbot\slave\win-hedscript.cpp @ 90]
WebKit!WebCore::SubresourceLoader::didFinishLoading+0x68 [c:\cygwin\home\buildbot\slave\win-celoader.cpp @ 299]
WebKit!WebCore::ResourceLoader::didFinishLoading+0x13 [c:\cygwin\home\buildbot\slave\win-oader.cpp @ 442]
WebKit!WebCore::didFinishLoading+0x2b [c:\cygwin\home\buildbot\slave\win-\cf\resourcehandlecfnet.cpp @ 301]
CFNetwork!CFReadStreamCreateWithFormArray+0x768f
CFNetwork!CFReadStreamCreateWithFormArray+0x9066
CFNetwork!CFReadStreamCreateWithFormArray+0x93d5
CFNetwork!CFReadStreamCreateWithFormArray+0x27d2
CFNetwork!CFReadStreamCreateWithFormArray+0x39d4
USER32!InternalCallWinProc+0x23
USER32!UserCallWinProcCheckWow+0x109
USER32!DispatchMessageWorker+0x3bc
USER32!DispatchMessageW+0xf
DumpRenderTree_747a0000!runTest+0x42e [c:\cygwin\home\buildbot\slave\win-release\build\tools\dumprendertree\win\dumprendertree.DumpRenderTree_747a0000!dllLauncherEntryPoint+0x73c [c:\cygwin\home\buildbot\slave\win-ndertree.cpp @ 1425]
DumpRenderTree!main+0x20b [c:\cygwin\home\buildbot\slave\win-release\build\tools\win\dlllauncher\dlllaunchermain.cpp @ 206]
DumpRenderTree!__tmainCRTStartup+0x10f [f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c @ 597]
kernel32!BaseThreadInitThunk+0xe
ntdll!__RtlUserThreadStart+0x70
ntdll!_RtlUserThreadStart+0x1b

[Filip Pizlo]

Looking at this now.

[Filip Pizlo]

(In reply to comment #6)
> Looking at this now.

Fix on the way.

[Filip Pizlo]

(In reply to comment #7)
> (In reply to comment #6)
> > Looking at this now.
> 
> Fix on the way.

Fixed in http://trac.webkit.org/changeset/126723