Bug 95013 - Array type checks and storage accesses should be uniformly represented and available to CSE
Summary: Array type checks and storage accesses should be uniformly represented and av...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 95014
Blocks: 91933
  Show dependency tree / graph
 
Reported: 2012-08-25 15:48 PDT by Filip Pizlo
Modified: 2012-08-26 15:35 PDT (History)
7 users (show)

See Also:

Attachments
work in progress (56.88 KB, patch)
2012-08-25 16:59 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
work in progress (62.50 KB, patch)
2012-08-26 00:06 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (74.86 KB, patch)
2012-08-26 11:40 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (74.83 KB, patch)
2012-08-26 11:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (75.17 KB, patch)
2012-08-26 12:15 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-08-25 15:48:12 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-08-25 16:59:28 PDT 
Created attachment 160580 [details]
work in progress
Comment 2 Filip Pizlo 2012-08-26 00:06:48 PDT 
Created attachment 160593 [details]
work in progress

It runs simple things.
Comment 3 Filip Pizlo 2012-08-26 11:40:11 PDT 
Created attachment 160607 [details]
the patch
Comment 4 WebKit Review Bot 2012-08-26 11:42:51 PDT 
Attachment 160607 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGArrayMode.h:66:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGGraph.h:79:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGGraph.h:79:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2012-08-26 11:57:28 PDT 
Created attachment 160608 [details]
the patch

Fixed style.
Comment 6 Filip Pizlo 2012-08-26 12:15:38 PDT 
Created attachment 160611 [details]
the patch

Minor build fix.
Comment 7 Oliver Hunt 2012-08-26 12:48:39 PDT 
Comment on attachment 160611 [details]
the patch

r=me
Comment 8 Filip Pizlo 2012-08-26 15:35:36 PDT 
Landed in http://trac.webkit.org/changeset/126715