Bug 94931 - Web Inspector: [WebGL] A follow up to simplify code with nested closures
Summary: Web Inspector: [WebGL] A follow up to simplify code with nested closures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 94799
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-24 06:19 PDT by Andrey Adaikin
Modified: 2012-08-24 07:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2012-08-24 06:20 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2012-08-24 06:44 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-08-24 06:19:04 PDT 
A follow-up to https://bugs.webkit.org/show_bug.cgi?id=94799
Comment 1 Andrey Adaikin 2012-08-24 06:20:33 PDT 
Created attachment 160411 [details]
Patch
Comment 2 Andrey Kosyakov 2012-08-24 06:39:19 PDT 
Comment on attachment 160411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160411&action=review

LGTM with a nit.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:908
> +        if (resource) {

if (!resource)
    return;
Comment 3 Andrey Adaikin 2012-08-24 06:44:00 PDT 
Created attachment 160414 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-24 07:38:40 PDT 
Comment on attachment 160414 [details]
Patch

Clearing flags on attachment: 160414

Committed r126585: <http://trac.webkit.org/changeset/126585>
Comment 5 WebKit Review Bot 2012-08-24 07:38:43 PDT 
All reviewed patches have been landed.  Closing bug.