WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94931
Web Inspector: [WebGL] A follow up to simplify code with nested closures
https://bugs.webkit.org/show_bug.cgi?id=94931
Summary
Web Inspector: [WebGL] A follow up to simplify code with nested closures
Andrey Adaikin
Reported
2012-08-24 06:19:04 PDT
A follow-up to
https://bugs.webkit.org/show_bug.cgi?id=94799
Attachments
Patch
(5.74 KB, patch)
2012-08-24 06:20 PDT
,
Andrey Adaikin
no flags
Details
Formatted Diff
Diff
Patch
(5.69 KB, patch)
2012-08-24 06:44 PDT
,
Andrey Adaikin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Adaikin
Comment 1
2012-08-24 06:20:33 PDT
Created
attachment 160411
[details]
Patch
Andrey Kosyakov
Comment 2
2012-08-24 06:39:19 PDT
Comment on
attachment 160411
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=160411&action=review
LGTM with a nit.
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:908 > + if (resource) {
if (!resource) return;
Andrey Adaikin
Comment 3
2012-08-24 06:44:00 PDT
Created
attachment 160414
[details]
Patch
WebKit Review Bot
Comment 4
2012-08-24 07:38:40 PDT
Comment on
attachment 160414
[details]
Patch Clearing flags on attachment: 160414 Committed
r126585
: <
http://trac.webkit.org/changeset/126585
>
WebKit Review Bot
Comment 5
2012-08-24 07:38:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug