Bug 94799 - Web Inspector: [WebGL] Implement custom wrap functions on GL context
Summary: Web Inspector: [WebGL] Implement custom wrap functions on GL context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks: 94931
  Show dependency tree / graph
 
Reported: 2012-08-23 05:00 PDT by Andrey Adaikin
Modified: 2012-08-24 06:19 PDT (History)
11 users (show)

See Also:

Attachments
Patch (14.55 KB, patch)
2012-08-23 05:04 PDT, Andrey Adaikin 		pfeldman: review+
Details | Formatted Diff | Diff
Patch to land (14.58 KB, patch)
2012-08-24 05:14 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-08-23 05:00:19 PDT 
Yet another step towards WebGL instrumentation.
Comment 1 Andrey Adaikin 2012-08-23 05:04:36 PDT 
Created attachment 160132 [details]
Patch
Comment 2 Pavel Feldman 2012-08-24 04:39:15 PDT 
Comment on attachment 160132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884
> +    "createBuffer": WebGLBufferResource,

I would implement this as array of pairs (arrays) so that you did not need to use Object.keys.
Comment 3 Andrey Adaikin 2012-08-24 05:13:48 PDT 
Comment on attachment 160132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884
>> +    "createBuffer": WebGLBufferResource,
> 
> I would implement this as array of pairs (arrays) so that you did not need to use Object.keys.

done.
Comment 4 Andrey Adaikin 2012-08-24 05:14:26 PDT 
Created attachment 160400 [details]
Patch to land
Comment 5 Andrey Kosyakov 2012-08-24 05:23:49 PDT 
Committed r126574: <http://trac.webkit.org/changeset/126574>