RESOLVED FIXED94799
Web Inspector: [WebGL] Implement custom wrap functions on GL context 
https://bugs.webkit.org/show_bug.cgi?id=94799
Summary Web Inspector: [WebGL] Implement custom wrap functions on GL context
Andrey Adaikin
Reported 2012-08-23 05:00:19 PDT
Yet another step towards WebGL instrumentation.
Attachments
Patch (14.55 KB, patch)
2012-08-23 05:04 PDT, Andrey Adaikin 		pfeldman: review+
DetailsFormatted DiffDiff
Patch to land (14.58 KB, patch)
2012-08-24 05:14 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2012-08-23 05:04:36 PDT
Created attachment 160132 [details] Patch
Pavel Feldman
Comment 2 2012-08-24 04:39:15 PDT
Comment on attachment 160132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review > Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884 > + "createBuffer": WebGLBufferResource, I would implement this as array of pairs (arrays) so that you did not need to use Object.keys.
Andrey Adaikin
Comment 3 2012-08-24 05:13:48 PDT
Comment on attachment 160132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review >> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884 >> + "createBuffer": WebGLBufferResource, > > I would implement this as array of pairs (arrays) so that you did not need to use Object.keys. done.
Andrey Adaikin
Comment 4 2012-08-24 05:14:26 PDT
Created attachment 160400 [details] Patch to land
Andrey Kosyakov
Comment 5 2012-08-24 05:23:49 PDT
Committed r126574: <http://trac.webkit.org/changeset/126574>
Note You need to log in before you can comment on or make changes to this bug.