Bug 94926 – Remove parent pointer from StyleSheetContents and StyleRuleImport

• Status: RESOLVED
• Resolution: LATER
• Component: CSS

[Antti Koivisto]

To able to cache and share imported stylesheets they must not have parent pointers.

[Antti Koivisto]

Created attachment 160407 [details]
patch

[WebKit Review Bot]

Comment on attachment 160407 [details]
patch

Attachment 160407 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13597129

New failing tests:
fast/dom/HTMLLinkElement/link-onerror.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html

[WebKit Review Bot]

Created attachment 160412 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Antti Koivisto]

Created attachment 160612 [details]
with less (?) bugs

[Andreas Kling]

Comment on attachment 160612 [details]
with less (?) bugs

View in context: https://bugs.webkit.org/attachment.cgi?id=160612&action=review

r=me

> Source/WebCore/css/StyleRuleImport.h:-59
> -    // NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it
> -    // to avoid adding a vptr to StyleRuleImport.
> -    class ImportedStyleSheetClient : public CachedStyleSheetClient {

Glad to see this hack disappear!

> Source/WebCore/css/StyleSheetContents.cpp:340
> +            m_didLoadErrorOccur = true;

Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.

[Antti Koivisto]

(In reply to comment #5)
> Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.

Yeah, I was trying to resist unrelated refactorings.

[Antti Koivisto]

http://trac.webkit.org/changeset/126717

[Csaba Osztrogonác]

(In reply to comment #7)
> http://trac.webkit.org/changeset/126717

It caused a regression, could you check it, please? 
Here is the new bug report - https://bugs.webkit.org/show_bug.cgi?id=95070

[Csaba Osztrogonác]

Please don't ignore the regression you caused - https://bugs.webkit.org/show_bug.cgi?id=95070

[Alexey Proskuryakov]

Rolled out in <http://trac.webkit.org/changeset/128637>, because this caused flakiness.

[Ahmad Saleem]

Is this need anymore or we can mark this as "RESOLVED LATER"? Thanks!