Bug 94926 - Remove parent pointer from StyleSheetContents and StyleRuleImport
Summary: Remove parent pointer from StyleSheetContents and StyleRuleImport
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 95070
Blocks: 77745
  Show dependency tree / graph
 
Reported: 2012-08-24 05:41 PDT by Antti Koivisto
Modified: 2022-09-14 22:57 PDT (History)
11 users (show)

See Also:

Attachments
patch (30.01 KB, patch)
2012-08-24 06:00 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (672.88 KB, application/zip)
2012-08-24 06:38 PDT, WebKit Review Bot 		no flags Details
with less (?) bugs (30.47 KB, patch)
2012-08-26 12:23 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-08-24 05:41:52 PDT 
To able to cache and share imported stylesheets they must not have parent pointers.
Comment 1 Antti Koivisto 2012-08-24 06:00:47 PDT 
Created attachment 160407 [details]
patch
Comment 2 WebKit Review Bot 2012-08-24 06:38:45 PDT 
Comment on attachment 160407 [details]
patch

Attachment 160407 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13597129

New failing tests:
fast/dom/HTMLLinkElement/link-onerror.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
Comment 3 WebKit Review Bot 2012-08-24 06:38:48 PDT 
Created attachment 160412 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Antti Koivisto 2012-08-26 12:23:27 PDT 
Created attachment 160612 [details]
with less (?) bugs
Comment 5 Andreas Kling 2012-08-26 14:17:34 PDT 
Comment on attachment 160612 [details]
with less (?) bugs

View in context: https://bugs.webkit.org/attachment.cgi?id=160612&action=review

r=me

> Source/WebCore/css/StyleRuleImport.h:-59
> -    // NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it
> -    // to avoid adding a vptr to StyleRuleImport.
> -    class ImportedStyleSheetClient : public CachedStyleSheetClient {

Glad to see this hack disappear!

> Source/WebCore/css/StyleSheetContents.cpp:340
> +            m_didLoadErrorOccur = true;

Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.
Comment 6 Antti Koivisto 2012-08-26 14:52:59 PDT 
(In reply to comment #5)
> Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.

Yeah, I was trying to resist unrelated refactorings.
Comment 7 Antti Koivisto 2012-08-26 16:48:58 PDT 
http://trac.webkit.org/changeset/126717
Comment 8 Csaba Osztrogonác 2012-08-27 05:56:12 PDT 
(In reply to comment #7)
> http://trac.webkit.org/changeset/126717

It caused a regression, could you check it, please? 
Here is the new bug report - https://bugs.webkit.org/show_bug.cgi?id=95070
Comment 9 Csaba Osztrogonác 2012-09-05 23:11:13 PDT 
Please don't ignore the regression you caused - https://bugs.webkit.org/show_bug.cgi?id=95070
Comment 10 Alexey Proskuryakov 2012-09-14 12:05:20 PDT 
Rolled out in <http://trac.webkit.org/changeset/128637>, because this caused flakiness.
Comment 11 Ahmad Saleem 2022-09-12 09:24:08 PDT 
Is this need anymore or we can mark this as "RESOLVED LATER"? Thanks!