Bug 94898 - [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7
Summary: [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-element...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 95055
Blocks: 94664
  Show dependency tree / graph
 
Reported: 2012-08-23 22:26 PDT by Dominic Cooney
Modified: 2012-08-27 01:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch 1 (2.26 KB, patch)
2012-08-23 22:45 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (2.26 KB, patch)
2012-08-23 22:49 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2012-08-23 22:26:40 PDT 
The following test:

fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html

started failing on Win7 at r126534 according to the flakiness dashboard:

<http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Ftime-multiple-fields%2Ftime-multiple-fields-appearance-pseudo-elements.html>

It looks like the image results differ in the seconds field – the expectation is :56, but the actual has :00 seconds.
Comment 1 yosin 2012-08-23 22:45:41 PDT 
Created attachment 160331 [details]
Patch 1
Comment 2 yosin 2012-08-23 22:46:10 PDT 
Comment on attachment 160331 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Dominic Cooney 2012-08-23 22:48:33 PDT 
I assume this will need rebaselining?
Comment 4 Kent Tamura 2012-08-23 22:48:35 PDT 
Comment on attachment 160331 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=160331&action=review

> LayoutTests/ChangeLog:2
> +2012-08-23  Yoshifumi Inoue <yosin@chromium.org>
> +        [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7

Need a blank line before the description line.
Comment 5 yosin 2012-08-23 22:49:17 PDT 
Created attachment 160332 [details]
Patch 2
Comment 6 yosin 2012-08-23 22:50:14 PDT 
Comment on attachment 160332 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Update ChangeLong
Comment 7 Kent Tamura 2012-08-23 23:07:44 PDT 
Comment on attachment 160332 [details]
Patch 2

ok
Comment 8 yosin 2012-08-23 23:09:52 PDT 
Comment on attachment 160332 [details]
Patch 2

Clearing flags on attachment: 160332

Committed r126545: <http://trac.webkit.org/changeset/126545>
Comment 9 yosin 2012-08-23 23:09:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Kent Tamura 2012-08-23 23:16:22 PDT 
(In reply to comment #3)
> I assume this will need rebaselining?

No. This patch has updated an expectation.
Comment 11 Julien Chaffraix 2012-08-24 10:41:20 PDT 
This patch still didn't solve the issue and I re-disabled the tests & filed a follow-up bug (bug 94951) about it.