[EFL] Update pixel test expectations for layout test fast/forms/
Created attachment 159899 [details] Patch 1 Uploaded pixel expectations are little bit different from original ones. Bugzilla has upload limit, so I splited patch to 3 pieces. Is it possible to upload like this?
Created attachment 159900 [details] Patch 2
Created attachment 159901 [details] Patch 3
Created attachment 160068 [details] Patch with big file option.
fast/forms/listbox-hit-test-zoomed-expected.png looks wrong; it should be skipped and a bug report should be created. Ditto for menulist-restrict-line-height-expected.png, fast/forms/search-cancel-button-style-sharing-expected.png and fast/forms/search-rtl-expected.png. fast/forms/menulist-narrow-width-expected.png, fast/forms/select-baseline-expected.png and fast/forms/menulist-style-color-expected.png all seem to be suffering from the same regression. Perhaps fast/forms/select-style-expected.png is having the same bug as well. The scrollbar isn't being fully rendered in fast/forms/textarea-scroll-height-expected.png and fast/forms/textarea-scrolled-type-expected.png (I guess that's bug 85484).
(In reply to comment #5) > fast/forms/listbox-hit-test-zoomed-expected.png looks wrong; it should be skipped and a bug report should be created. > You're right. Test 2 is failing. I will make this test skip. > Ditto for menulist-restrict-line-height-expected.png, fast/forms/search-cancel-button-style-sharing-expected.png and fast/forms/search-rtl-expected.png. > For fast/forms/menulist-restrict-line-height.html, text in the popup button is clipped. Need skip. For fast/forms/search-cancel-button-style-sharing.html and fast/forms/search-rtl.html, cancel mark is not displayed on search box. Need skip. > fast/forms/menulist-narrow-width-expected.png, fast/forms/select-baseline-expected.png and fast/forms/menulist-style-color-expected.png all seem to be suffering from the same regression. Perhaps fast/forms/select-style-expected.png is having the same bug as well. > These tests have styling problem. Need skip. > The scrollbar isn't being fully rendered in fast/forms/textarea-scroll-height-expected.png and fast/forms/textarea-scrolled-type-expected.png (I guess that's bug 85484). These tests have scroll bar displaying problem. Need skip.
Created attachment 160136 [details] Patch The wrong test expectations will be removed by bug 94798.
Anyone double checking ?
Rebased .png flies pass --pixel test in my linux box.
Comment on attachment 160136 [details] Patch Looks OK now, cq+'ing.
Comment on attachment 160136 [details] Patch Clearing flags on attachment: 160136 Committed r126466: <http://trac.webkit.org/changeset/126466>
All reviewed patches have been landed. Closing bug.