We temporarily disabled image diffs on the wk2 bots, which essentially skips all of the ref tests (we will still catch crashes and timeouts, at least). https://bugs.webkit.org/show_bug.cgi?id=94517 We should re-enable the check (and revert that change) as soon as we can.
This should also re-enable treating ImageDiff failures as test failures for the wk2 bots (disabled in https://bugs.webkit.org/show_bug.cgi?id=94396 ).
Created attachment 159757 [details] Patch
Comment on attachment 159757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270 > - # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't Can we close this bug now?
(In reply to comment #3) > (From update of attachment 159757 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270 > > - # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't > > Can we close this bug now? Not just yet; I'm still seeing the failures on my machine, but smfr hasn't been able to reproduce them, so we're going to land this and see if he sees them or if we see issues on the bots.
Committed r126189: <http://trac.webkit.org/changeset/126189>