Bug 94540 - re-enable image diff for the wk2 bots ASAP
Summary: re-enable image diff for the wk2 bots ASAP
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 91962 94396
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-20 16:03 PDT by Dirk Pranke
Modified: 2012-08-21 14:39 PDT (History)
8 users (show)

See Also:


Attachments
Patch (6.07 KB, patch)
2012-08-21 13:30 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-08-20 16:03:40 PDT
We temporarily disabled image diffs on the wk2 bots, which essentially skips all of the ref tests (we will still catch crashes and timeouts, at least).

https://bugs.webkit.org/show_bug.cgi?id=94517

We should re-enable the check (and revert that change) as soon as we can.
Comment 1 Dirk Pranke 2012-08-20 16:05:37 PDT
This should also re-enable treating ImageDiff failures as test failures for the wk2 bots (disabled in https://bugs.webkit.org/show_bug.cgi?id=94396 ).
Comment 2 Dirk Pranke 2012-08-21 13:30:08 PDT
Created attachment 159757 [details]
Patch
Comment 3 Ojan Vafai 2012-08-21 14:22:23 PDT
Comment on attachment 159757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270
> -            # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't

Can we close this bug now?
Comment 4 Dirk Pranke 2012-08-21 14:36:29 PDT
(In reply to comment #3)
> (From update of attachment 159757 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270
> > -            # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't
> 
> Can we close this bug now?

Not just yet; I'm still seeing the failures on my machine, but smfr hasn't been able to reproduce them, so we're going to land this and see if he sees them or if we see issues on the bots.
Comment 5 Dirk Pranke 2012-08-21 14:39:15 PDT
Committed r126189: <http://trac.webkit.org/changeset/126189>