Bug 94396 - nrwt: don't fail tests if ImageDiff fails on the wk2 ports
Summary: nrwt: don't fail tests if ImageDiff fails on the wk2 ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 94540
  Show dependency tree / graph
 
Reported: 2012-08-17 16:57 PDT by Dirk Pranke
Modified: 2012-08-20 16:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2012-08-17 17:00 PDT, Dirk Pranke 		beidson: review-
Details | Formatted Diff | Diff
fix typoed bug # in comment (2.14 KB, patch)
2012-08-17 17:21 PDT, Dirk Pranke 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-08-17 16:57:23 PDT 
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
Comment 1 Dirk Pranke 2012-08-17 17:00:31 PDT 
Created attachment 159229 [details]
Patch
Comment 2 Brady Eidson 2012-08-17 17:12:46 PDT 
Comment on attachment 159229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159229&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:270
> +            # https://bugs.webkit.org/show_bug.cgi?id=819262; ImageDiff doesn't

Wrong bug id here.
Comment 3 Dirk Pranke 2012-08-17 17:21:18 PDT 
Created attachment 159238 [details]
fix typoed bug # in comment
Comment 4 Dirk Pranke 2012-08-17 17:26:02 PDT 
Committed r125954: <http://trac.webkit.org/changeset/125954>
Comment 5 Simon Fraser (smfr) 2012-08-20 11:20:35 PDT 
But why are we running ImageDiff at all on the Mac ports, other than for ref tests?
Comment 6 Dirk Pranke 2012-08-20 11:25:33 PDT 
(In reply to comment #5)
> But why are we running ImageDiff at all on the Mac ports, other than for ref tests?

You're not; these are ref tests that are failing.