Bug 94435 - [GTK] Split WebCore/platform into a separate library
Summary: [GTK] Split WebCore/platform into a separate library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
: 101310 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-19 15:30 PDT by Gustavo Noronha (kov)
Modified: 2012-12-11 18:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (87.72 KB, patch)
2012-08-19 15:37 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Kov's patch (91.16 KB, patch)
2012-11-15 02:22 PST, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-08-19 15:30:39 PDT 
[GTK] Split WebCore/platform into a separate library
Comment 1 Gustavo Noronha (kov) 2012-08-19 15:37:39 PDT 
Created attachment 159309 [details]
Patch
Comment 2 Martin Robinson 2012-08-20 10:37:24 PDT 
Comment on attachment 159309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159309&action=review

> Source/WebCore/GNUmakefile.am:1055
> +	-DBUILDING_WEBKIT \
> +	$(global_cppflags) \
> +	$(webcore_cppflags) \
> +	$(webcoregtk_cppflags) \
> +	$(javascriptcore_cppflags) \
> +	-fno-strict-aliasing \
> +	$(CAIRO_CFLAGS) \
> +	$(CLUTTER_CFLAGS) \
> +	$(COVERAGE_CFLAGS) \
> +	$(ENCHANT_CFLAGS) \
> +	$(GAMEPAD_CFLAGS) \
> +	$(GEOCLUE_CFLAGS) \
> +	$(GLIB_CFLAGS) \
> +	$(GSTREAMER_CFLAGS) \
> +	$(LIBSOUP_CFLAGS) \
> +	$(LIBXML_CFLAGS) \
> +	$(LIBXSLT_CFLAGS) \
> +	$(PANGO_CFLAGS) \
> +	$(SQLITE3_CFLAGS) \
> +	$(UNICODE_CFLAGS) \
> +	$(XRENDER_CFLAGS) \
> +	$(XT_CFLAGS)

Perhaps we should abstract this away into a variable for use by all WebCore libraries?
Comment 3 Gustavo Noronha (kov) 2012-08-22 08:47:33 PDT 
Committed r126306: <http://trac.webkit.org/changeset/126306>
Comment 4 Carlos Garcia Campos 2012-08-23 06:36:10 PDT 
Reopening, this was rolled out, see:

https://bugs.webkit.org/show_bug.cgi?id=94797
Comment 5 Philippe Normand 2012-11-15 02:22:08 PST 
Created attachment 174377 [details]
Kov's patch
Comment 6 Philippe Normand 2012-11-15 02:23:40 PST 
I just rebased the patch against ToT. Worked fine here, minibrowser with flash plugin.
Comment 7 Carlos Garcia Campos 2012-11-15 02:24:59 PST 
I'll try it out again, thanks!
Comment 8 Carlos Garcia Campos 2012-11-15 03:41:27 PST 
(In reply to comment #7)
> I'll try it out again, thanks!

Works for me too!
Comment 9 Gustavo Noronha (kov) 2012-11-15 17:06:34 PST 
Committed r134864: <http://trac.webkit.org/changeset/134864>
Comment 10 Halton Huo 2012-12-11 18:48:09 PST 
*** Bug 101310 has been marked as a duplicate of this bug. ***