Bug 94797 – REGRESSION(r126306): it broke the plugin process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

http://trac.webkit.org/changeset/126306 broke plugins in WebKit2:

http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/26291/steps/API%20tests/logs/stdio

All plugins fail to load due to a runtime symbol lookup error in the plugin process. It can be easily reproduced:

$ ../Tools/gtk/run-with-jhbuild Release/Programs/WebKitPluginProcess -scanplugin Release/TestNetscapePlugin/.libs/libtestnetscapeplugin.so
/home/cgarcia/WebKit/WebKitBuild/Release/Programs/.libs/lt-WebKitPluginProcess: symbol lookup error: /home/cgarcia/WebKit/WebKitBuild/Release/Programs/.libs/lt-WebKitPluginProcess: undefined symbol: _ZN7WebCore21WebKitFontFamilyNames14standardFamilyE


I think it also broke make distcheck.

[Carlos Garcia Campos]

Created attachment 160131 [details]
Rollout r126306

Ok, I manually rolled out the webcore split, because other changes were added to the makefiles and automatic rollout wouldn't apply. I propose to roll this out for now to be able to finish the release and fix the problems afterwards.

[Carlos Garcia Campos]

Btw, the make distcheck error I got was very similar (if not the same) to the one we had when supplemental idl stuff was added:

  CXX    Source/WebCore/platform/graphics/libWebCorePlatform_la-Pattern.lo
In file included from ../Source/WebCore/bindings/js/ScriptController.h:26:0,
                 from ../Source/WebCore/page/Frame.h:40,
                 from ../Source/WebCore/platform/graphics/MediaPlayer.cpp:33:
../Source/WebCore/bindings/js/JSDOMWindowShell.h:32:25: error fatal: JSDOMWindow.h: No existe el archivo o el directorio
compilación terminada.

[Carlos Garcia Campos]

I'm asking for review because I did the rollout manually, so I wanted to make sure ews was green and someone else had looked at the patch before landing it, just to be extra sure.

[Xan Lopez]

Comment on attachment 160131 [details]
Rollout r126306

Looks OK to me.

[WebKit Review Bot]

Comment on attachment 160131 [details]
Rollout r126306

Clearing flags on attachment: 160131

Committed r126421: <http://trac.webkit.org/changeset/126421>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

I'm trying kov's patch. It works fine with a debug build (flash works in minibrowser). Trying a release build now

[Philippe Normand]

Release build works too...