Bug 94303 – [WK2] [GTK] build fails when the build dir is in a separate filesystem/mountpoint

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomeu Vizoso]

The symbolic link created in ./DerivedSources/WebKit2/webkit2gtk/include/webkit2 points to /run/media/tomeu/backup/webkit-gtk+-build//home/tomeu/bosch-prefix/source/webkit-gtk+/Source/WebKit2/UIProcess/API/gtk

The build dir is /run/media/tomeu/backup/webkit-gtk+-build/ and the sources are in /home/tomeu/bosch-prefix/source/webkit-gtk+, and of course the dir /run/media/tomeu/backup/webkit-gtk+-build//home/tomeu/bosch-prefix/source/webkit-gtk+/Source/WebKit2/UIProcess/API/gtk doesn't exist so the link is broken.

[Tomeu Vizoso]

Created attachment 159018 [details]
Patch

[Carlos Garcia Campos]

Have you checked this doesn't break make distcheck?

[Tomeu Vizoso]

(In reply to comment #2)
> Have you checked this doesn't break make distcheck?

Just tried, and seems that distcheck is broken in my system in the same way with or without my patch, regardless of where the build directory is:

[tomeu@cizrna (master) webkit-gtk+]$ make distcheck
make  dist-xz am__post_remove_distdir='@:'
make[1]: Entering directory `/home/tomeu/bosch-prefix/source/webkit-gtk+'
if test -d "webkit-1.9.6"; then find "webkit-1.9.6" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "webkit-1.9.6" || { sleep 5 && rm -rf "webkit-1.9.6"; }; else :; fi
test -d "webkit-1.9.6" || mkdir "webkit-1.9.6"
make  \
  top_distdir="webkit-1.9.6" distdir="webkit-1.9.6" \
  dist-hook
make[2]: Entering directory `/home/tomeu/bosch-prefix/source/webkit-gtk+'
  CXX      Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-TextCheckerClientGtk.lo
  CXX      Source/WebCore/bindings/gobject/libwebkitgtk_3_0_la-ConvertToUTF8String.lo
  CXX      Source/WebCore/bindings/gobject/libwebkitgtk_3_0_la-DOMObjectCache.lo
In file included from ./Source/WebCore/dom/EventTarget.h:36:0,
                 from ./Source/WebCore/dom/Node.h:29,
                 from ./Source/WebCore/dom/ContainerNode.h:28,
                 from ./Source/WebCore/dom/Document.h:33,
                 from Source/WebCore/bindings/gobject/DOMObjectCache.cpp:22:
./Source/WebCore/dom/EventNames.h:25:29: fatal error: EventInterfaces.h: No such file or directory
compilation terminated.
make[2]: *** [Source/WebCore/bindings/gobject/libwebkitgtk_3_0_la-DOMObjectCache.lo] Error 1
make[2]: Leaving directory `/home/tomeu/bosch-prefix/source/webkit-gtk+'
make[1]: *** [distdir] Error 2
make[1]: Leaving directory `/home/tomeu/bosch-prefix/source/webkit-gtk+'
make: *** [dist] Error 2

[Carlos Garcia Campos]

The patch seems to break make distcheck indeed:

In file included from DerivedSources/WebKit2/webkit2gtk/webkit2/WebKitEnumTypes.cpp:6:0:
././DerivedSources/WebKit2/webkit2gtk/webkit2/WebKitEnumTypes.h:13:35: error fatal: webkit2/WebKitDefines.h: No existe el archivo o el directorio
compilación terminada.
  GEN    DerivedSources/webkit/webkitenumtypes.cpp
  GEN    stamp-webkitenumtypes.h
  CXXLD  libWTF.la
  CXX    DerivedSources/webkit/libwebkitgtk_3_0_la-webkitenumtypes.lo
  CXX    DerivedSources/WebCore/libWebCore_la-InspectorFrontend.lo
  CXX    DerivedSources/WebCore/libWebCore_la-InspectorTypeBuilder.lo
make[1]: *** [DerivedSources/WebKit2/webkit2gtk/webkit2/libwebkit2gtk_3_0_la-WebKitEnumTypes.lo] Error 1
make[1]: *** Se espera a que terminen otras tareas....
make[1]: se sale del directorio `/home/cgarcia/src/git/gnome/WebKit/WebKitBuild/webkit-1.9.6/_build'
make: *** [distcheck] Error 1

[Martin Robinson]

Comment on attachment 159018 [details]
Patch

r- based on Carlos' comment.

[Alberto Garcia]

This seems to be working fine now (see bug 121296).

Please reopen if you think there's still a problem.