Bug 121296 - [GTK] Fails to compile if the build directory is in a different partition
Summary: [GTK] Fails to compile if the build directory is in a different partition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-13 05:25 PDT by Alberto Garcia
Modified: 2013-09-14 11:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2013-09-13 05:27 PDT, Alberto Garcia
cgarcia: review+
Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2013-09-14 09:54 PDT, Alberto Garcia
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-13 05:25:48 PDT
The problem is the os.link() call in gtkdoc.py
Comment 1 Alberto Garcia 2013-09-13 05:27:04 PDT
Created attachment 211543 [details]
Patch
Comment 2 Alberto Garcia 2013-09-14 01:35:08 PDT
Committed r155757: <http://trac.webkit.org/changeset/155757>
Comment 3 Martin Robinson 2013-09-14 08:51:51 PDT
os.symlink doesn't work on Windows.
Comment 4 Martin Robinson 2013-09-14 08:52:28 PDT
I think it sometimes works in cygwin, but not always.
Comment 5 Alberto Garcia 2013-09-14 09:07:46 PDT
Maybe we can try link() first and use symlink() if it fails.
Comment 6 Alberto Garcia 2013-09-14 09:54:00 PDT
Created attachment 211651 [details]
Patch

Ok, this patch reverts to using os.link() and only uses os.symlink() as a fallback.
Comment 7 Martin Robinson 2013-09-14 10:42:57 PDT
Comment on attachment 211651 [details]
Patch

Great. Thanks!
Comment 8 Alberto Garcia 2013-09-14 11:02:44 PDT
Committed r155772: <http://trac.webkit.org/changeset/155772>