We have complex logic in PopupContainer::layoutAndCalculateWidgetRect(). But we don't have automated tests for it.
Created attachment 159028 [details] Patch 1
Comment on attachment 159028 [details] Patch 1 Attachment 159028 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13518513
Created attachment 159043 [details] Patch 2 Fix signed-unsinged comparison
Comment on attachment 159043 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=159043&action=review > Source/WebCore/platform/chromium/PopupContainer.h:122 > + static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const FloatRect& screen, bool isRTL, const int rtlOffset, PopupContent*, bool& needToResizeView); This method has too many parameters. Probably these can be packed into a separate class then this method can be a part of that class.
Comment on attachment 159043 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=159043&action=review >> Source/WebCore/platform/chromium/PopupContainer.h:122 >> + static IntRect layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const FloatRect& screen, bool isRTL, const int rtlOffset, PopupContent*, bool& needToResizeView); > > This method has too many parameters. Probably these can be packed into a separate class then this method can be a part of that class. Sounds good. I might work on it later.
Comment on attachment 159043 [details] Patch 2 Clearing flags on attachment: 159043 Committed r126121: <http://trac.webkit.org/changeset/126121>
All reviewed patches have been landed. Closing bug.