Bug 94087 - [Chromium] Refactoring: Introduce a new function for some part of PopupContainer::layoutAndCalculateWidgetRect()
Summary: [Chromium] Refactoring: Introduce a new function for some part of PopupContai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 94086
  Show dependency treegraph
 
Reported: 2012-08-15 02:00 PDT by Kent Tamura
Modified: 2012-08-15 23:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (11.37 KB, patch)
2012-08-15 02:21 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch for landing (11.44 KB, patch)
2012-08-15 22:10 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-08-15 02:00:35 PDT
Refactoring: Introduce a new function for some part of PopupContainer::layoutAndCalculateWidgetRect()
Comment 1 Kent Tamura 2012-08-15 02:21:04 PDT
Created attachment 158530 [details]
Patch
Comment 2 Hajime Morrita 2012-08-15 22:02:37 PDT
Comment on attachment 158530 [details]
Patch

The code move itself looks sane. Please explain the intention behind this change if there is any.
Comment 3 Kent Tamura 2012-08-15 22:10:29 PDT
Created attachment 158708 [details]
Patch for landing

Update ChangeLog
Comment 4 WebKit Review Bot 2012-08-15 23:01:49 PDT
Comment on attachment 158708 [details]
Patch for landing

Clearing flags on attachment: 158708

Committed r125749: <http://trac.webkit.org/changeset/125749>
Comment 5 WebKit Review Bot 2012-08-15 23:01:53 PDT
All reviewed patches have been landed.  Closing bug.