Bug 93840 – Relative units are not set when the canvas has no parent

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Thiago Marcos P. Santos]

The spec says that in this case, it should be relative to the defaults (10px sans-serif).

[Thiago Marcos P. Santos]

Created attachment 158011 [details]
Patch

[Kenneth Rohde Christiansen]

Julien can you have a look?

[WebKit Review Bot]

Comment on attachment 158011 [details]
Patch

Attachment 158011 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13494273

New failing tests:
http/tests/cache/post-redirect-get.php
platform/chromium/virtual/gpu/fast/canvas/canvas-font-ex-units-crash.html
http/tests/cache/post-with-cached-subresources.php
fast/canvas/canvas-font-ex-units-crash.html

[WebKit Review Bot]

Created attachment 158149 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Thiago Marcos P. Santos]

Created attachment 158297 [details]
Patch

[Thiago Marcos P. Santos]

I have to update this patch after bug 93910 lands.

[Thiago Marcos P. Santos]

Created attachment 158342 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 158342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158342&action=review

> LayoutTests/ChangeLog:9
> +        and fixed wrong test cases.

updated test case which was fixed by the W3C

[Thiago Marcos P. Santos]

Created attachment 158344 [details]
Patch

[WebKit Review Bot]

Comment on attachment 158344 [details]
Patch

Rejecting attachment 158344 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
sts/2d.text.font.parse.size.percentage-expected.txt'
patching file LayoutTests/platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt
rm 'LayoutTests/platform/mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt'
patching file LayoutTests/platform/qt/Skipped
Hunk #1 succeeded at 2110 (offset -1 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13504290

[Thiago Marcos P. Santos]

Created attachment 158526 [details]
Patch

[WebKit Review Bot]

Comment on attachment 158526 [details]
Patch

Clearing flags on attachment: 158526

Committed r125663: <http://trac.webkit.org/changeset/125663>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.