Currently, CanvasRenderContext2D::font() just returns the literal string that was passed in to the setter, instead of the serialized form of the current font (as http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-font says). This is making us fail these theses: canvas/philip/tests/2d.text.font.parse.basic.html canvas/philip/tests/2d.text.font.parse.complex.html canvas/philip/tests/2d.text.font.parse.invalid.html canvas/philip/tests/2d.text.font.parse.size.percentage.default.html canvas/philip/tests/2d.text.font.parse.size.percentage.html canvas/philip/tests/2d.text.font.parse.system.html
Created attachment 157796 [details] Patch
Created attachment 157797 [details] Patch
Comment on attachment 157797 [details] Patch Attachment 157797 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13476348 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-font-ex-units-crash.html fast/canvas/canvas-font-ex-units-crash.html
Created attachment 157817 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 158000 [details] Patch
Comment on attachment 158000 [details] Patch I suppose the unskipped tests covers this fully
Comment on attachment 158000 [details] Patch Rejecting attachment 158000 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [css] Remove "default" switch case from CSS primitive value mappings When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13481832
Created attachment 158055 [details] Patch
Comment on attachment 158055 [details] Patch Rejecting attachment 158055 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13484853
Created attachment 158082 [details] Patch Rebased once again. I really don't see the reason why cq is having issues with this patch. I'm not getting any conflict here.
Comment on attachment 158082 [details] Patch Clearing flags on attachment: 158082 Committed r125450: <http://trac.webkit.org/changeset/125450>
All reviewed patches have been landed. Closing bug.
Unfortunately this has broken Apple Mac Lion WK1 tests. Those are not running on the EWS at the moment. http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125465%20(2304)/results.html
I've filed https://bugs.webkit.org/show_bug.cgi?id=93910