Now the nrwt doesn't warn if a test from the skipped list doesn't exist.
seems reasonable and a trivial change (test_expectations.py:889)
Created attachment 158558 [details]
Comment on attachment 158558 [details]
expectation_for_skipped_test() won't set .warnings, so it seems unlikely that this branch would ever execute. Also, checking for one warning and then printing another seems like a bad idea.
You should just test if the file (or directory) exists here and add a warning directly (or add that code into expectation_for_skipped_test().
Also, this change needs a test.
Created attachment 160986 [details]
Comment on attachment 160986 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=160986&action=review
> + _log.warning('The following test %s from the Skipped list doesn\'t exists!' % test_name)
Nit: "exist", not "exists", and I wouldn't use an exclamation point.
Committed r126992: <http://trac.webkit.org/changeset/126992>