Bug 93616 - Moving the common code from CodegeneratorJS/V8.pm to Codegenerator.pm
Summary: Moving the common code from CodegeneratorJS/V8.pm to Codegenerator.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vineet Chaudhary (vineetc)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 08:57 PDT by Vineet Chaudhary (vineetc)
Modified: 2012-08-10 01:46 PDT (History)
4 users (show)

See Also:

Attachments
patch (15.59 KB, patch)
2012-08-09 08:59 PDT, Vineet Chaudhary (vineetc) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vineet Chaudhary (vineetc) 2012-08-09 08:57:56 PDT 
IsArrayType() IsConstructorTemplate() IsTypedArrayType() these methods has the common implementaion for both V8 and JS and can be moved to
common place Codegenerator.pm.
This will also help to have checks in CodegeneratorCPP/ObjC/GObject.pm.
Ref. Bug93613
Comment 1 Vineet Chaudhary (vineetc) 2012-08-09 08:59:15 PDT 
Created attachment 157461 [details]
patch
Comment 2 Adam Barth 2012-08-09 10:58:05 PDT 
Comment on attachment 157461 [details]
patch

Ok.
Comment 3 Vineet Chaudhary (vineetc) 2012-08-09 23:31:15 PDT 
Comment on attachment 157461 [details]
patch

Thanks :)
Comment 4 WebKit Review Bot 2012-08-10 01:46:53 PDT 
Comment on attachment 157461 [details]
patch

Clearing flags on attachment: 157461

Committed r125261: <http://trac.webkit.org/changeset/125261>
Comment 5 WebKit Review Bot 2012-08-10 01:46:57 PDT 
All reviewed patches have been landed.  Closing bug.