Bug 93613 - Remove custom bindings from WaveShaperNode.
Summary: Remove custom bindings from WaveShaperNode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vineet Chaudhary (vineetc)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 05:38 PDT by Vineet Chaudhary (vineetc)
Modified: 2012-08-10 09:49 PDT (History)
10 users (show)

See Also:


Attachments
Patch (8.37 KB, patch)
2012-08-09 05:41 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff
patch_for_review (19.13 KB, patch)
2012-08-10 02:38 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vineet Chaudhary (vineetc) 2012-08-09 05:38:06 PDT
We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.
This was introduced in r91281.
Comment 1 Vineet Chaudhary (vineetc) 2012-08-09 05:41:24 PDT
Created attachment 157453 [details]
Patch
Comment 2 Vineet Chaudhary (vineetc) 2012-08-10 02:38:34 PDT
Created attachment 157691 [details]
patch_for_review

Updated patch for review.
Comment 3 Kentaro Hara 2012-08-10 04:59:00 PDT
Comment on attachment 157691 [details]
patch_for_review

Good refactoring!
Comment 4 WebKit Review Bot 2012-08-10 09:49:13 PDT
Comment on attachment 157691 [details]
patch_for_review

Clearing flags on attachment: 157691

Committed r125293: <http://trac.webkit.org/changeset/125293>
Comment 5 WebKit Review Bot 2012-08-10 09:49:19 PDT
All reviewed patches have been landed.  Closing bug.