Bug 93543 - Fix test results of network-no-source-const-shadow.html
Summary: Fix test results of network-no-source-const-shadow.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 91031
  Show dependency treegraph
 
Reported: 2012-08-08 15:59 PDT by Erik Arvidsson
Modified: 2012-08-08 22:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.72 KB, patch)
2012-08-08 16:01 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-08-08 15:59:37 PDT
Fix invalid test
Comment 1 Erik Arvidsson 2012-08-08 16:01:57 PDT
Created attachment 157318 [details]
Patch
Comment 2 Kentaro Hara 2012-08-08 17:18:28 PDT
Comment on attachment 157318 [details]
Patch

OK
Comment 3 WebKit Review Bot 2012-08-08 19:05:51 PDT
Comment on attachment 157318 [details]
Patch

Clearing flags on attachment: 157318

Committed r125138: <http://trac.webkit.org/changeset/125138>
Comment 4 WebKit Review Bot 2012-08-08 19:05:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Carlson 2012-08-08 19:27:07 PDT
Comment on attachment 157318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157318&action=review

> LayoutTests/media/network-no-source-const-shadow-expected.txt:11
> -PASS element.NETWORK_NO_SOURCE is 15
> +FAIL element.NETWORK_NO_SOURCE should be 3. Was 15.

Did you mean to land results with a failing test?
Comment 6 Erik Arvidsson 2012-08-08 22:04:16 PDT
(In reply to comment #5)
> (From update of attachment 157318 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157318&action=review
> 
> > LayoutTests/media/network-no-source-const-shadow-expected.txt:11
> > -PASS element.NETWORK_NO_SOURCE is 15
> > +FAIL element.NETWORK_NO_SOURCE should be 3. Was 15.
> 
> Did you mean to land results with a failing test?

Yes. The test is still useful but both V8 and JSC get the result wrong at the moment.

V8 bug is 91031
JSC bug is 93540