Bug 91031 - [V8] Enable es5_readonly
Summary: [V8] Enable es5_readonly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on: 91668 93543 93555
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 15:51 PDT by Erik Arvidsson
Modified: 2012-08-10 10:05 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2012-07-11 15:52 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (376.90 KB, application/zip)
2012-07-11 17:15 PDT, WebKit Review Bot
no flags Details
Patch (63.74 KB, patch)
2012-07-16 16:13 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (379.62 KB, application/zip)
2012-07-16 18:03 PDT, WebKit Review Bot
no flags Details
Patch (63.42 KB, patch)
2012-07-17 12:29 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (2.71 KB, patch)
2012-07-19 14:53 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (2.68 KB, patch)
2012-07-19 15:35 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch for landing (2.69 KB, patch)
2012-07-30 11:51 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (374.38 KB, application/zip)
2012-07-31 01:23 PDT, WebKit Review Bot
no flags Details
Patch (5.67 KB, patch)
2012-08-07 18:22 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (390.89 KB, application/zip)
2012-08-08 12:48 PDT, WebKit Review Bot
no flags Details
Patch (8.14 KB, patch)
2012-08-09 12:20 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2012-08-09 19:47 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-07-11 15:51:43 PDT
[V8] Enable es5_readonly
Comment 1 Erik Arvidsson 2012-07-11 15:52:46 PDT
Created attachment 151807 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-11 17:15:04 PDT
Comment on attachment 151807 [details]
Patch

Attachment 151807 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13198573

New failing tests:
http/tests/media/reload-after-dialog.html
editing/selection/5195166-1.html
editing/spelling/spelling-unified-emulation.html
editing/text-iterator/first-letter-word-boundary.html
editing/selection/5213963.html
http/tests/appcache/video.html
editing/deleting/4922367.html
editing/selection/5209984.html
editing/undo/replace-by-span-then-remove.html
css3/calc/border.html
editing/spelling/spelling-attribute-change.html
http/tests/media/pdf-served-as-pdf.html
css3/calc/padding.html
editing/spelling/spelling-hasspellingmarker.html
editing/selection/modify-up-on-rtl-wrapping-text.html
editing/selection/click-left-of-rtl-wrapping-text.html
http/tests/media/text-served-as-text.html
css3/filters/blur-filter-page-scroll-self.html
editing/execCommand/5939887.html
http/tests/media/video-error-abort.html
http/tests/media/remove-while-loading.html
http/tests/media/media-document.html
css3/calc/table-border-spacing.html
http/tests/media/video-cookie.html
http/tests/media/video-load-twice.html
Comment 3 WebKit Review Bot 2012-07-11 17:15:08 PDT
Created attachment 151818 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Erik Arvidsson 2012-07-16 16:13:53 PDT
Created attachment 152638 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-16 18:03:52 PDT
Comment on attachment 152638 [details]
Patch

Attachment 152638 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13261165

New failing tests:
http/tests/security/inactive-document-with-empty-security-origin.html
Comment 6 WebKit Review Bot 2012-07-16 18:03:56 PDT
Created attachment 152663 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 Erik Arvidsson 2012-07-17 12:29:45 PDT
Created attachment 152805 [details]
Patch
Comment 8 Erik Arvidsson 2012-07-19 14:53:12 PDT
Created attachment 153352 [details]
Patch
Comment 9 WebKit Review Bot 2012-07-19 15:28:51 PDT
Comment on attachment 153352 [details]
Patch

Attachment 153352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13309037
Comment 10 Erik Arvidsson 2012-07-19 15:35:31 PDT
Created attachment 153363 [details]
Patch
Comment 11 WebKit Review Bot 2012-07-19 15:41:37 PDT
Comment on attachment 153363 [details]
Patch

Attachment 153363 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13303097
Comment 12 Adam Barth 2012-07-27 02:06:49 PDT
Comment on attachment 153363 [details]
Patch

rs=me, assuming this lands cleanly.
Comment 13 Erik Arvidsson 2012-07-30 11:51:37 PDT
Created attachment 155332 [details]
Patch for landing
Comment 14 Erik Arvidsson 2012-07-30 18:02:45 PDT
Comment on attachment 155332 [details]
Patch for landing

This is going to fail again. This exposes another V8 binding bug related to [DoNotCheckSecurity]
Comment 15 WebKit Review Bot 2012-07-31 01:23:18 PDT
Comment on attachment 155332 [details]
Patch for landing

Attachment 155332 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13389595

New failing tests:
fast/dom/Window/get-set-properties.html
media/network-no-source-const-shadow.html
fast/js/toString-and-valueOf-override.html
Comment 16 WebKit Review Bot 2012-07-31 01:23:23 PDT
Created attachment 155463 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 17 Erik Arvidsson 2012-08-07 18:22:51 PDT
Created attachment 157073 [details]
Patch
Comment 18 WebKit Review Bot 2012-08-08 12:48:09 PDT
Comment on attachment 157073 [details]
Patch

Attachment 157073 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13460272

New failing tests:
media/network-no-source-const-shadow.html
Comment 19 WebKit Review Bot 2012-08-08 12:48:13 PDT
Created attachment 157272 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 20 Erik Arvidsson 2012-08-09 12:20:27 PDT
Created attachment 157512 [details]
Patch
Comment 21 Erik Arvidsson 2012-08-09 19:47:11 PDT
Created attachment 157616 [details]
Patch
Comment 22 Adam Barth 2012-08-10 09:36:52 PDT
congrats
Comment 23 WebKit Review Bot 2012-08-10 10:05:27 PDT
Comment on attachment 157616 [details]
Patch

Clearing flags on attachment: 157616

Committed r125296: <http://trac.webkit.org/changeset/125296>
Comment 24 WebKit Review Bot 2012-08-10 10:05:33 PDT
All reviewed patches have been landed.  Closing bug.