Bug 93291 - adding windows 64-bit definition files for JavaScriptCore and WebKit2CFLite
Summary: adding windows 64-bit definition files for JavaScriptCore and WebKit2CFLite
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: https://github.com/achristensen07/web...
Depends on: 103687
  Show dependency treegraph
Reported: 2012-08-06 13:01 PDT by Alex Christensen
Modified: 2013-10-02 16:07 PDT (History)
3 users (show)

See Also:

Patch (40.94 KB, patch)
2012-08-06 13:05 PDT, Alex Christensen
paroga: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2012-08-06 13:01:33 PDT
I changed all the symbols to their 64-bit counterparts (no trivial task) and think it ought to be included in the repository so nobody else has to do it, and so that it can be maintained by the community.  https://github.com/achristensen07/webkit64prep
Comment 1 Alex Christensen 2012-08-06 13:05:32 PDT
Created attachment 156750 [details]
Comment 2 Patrick R. Gansterer 2012-08-06 14:58:57 PDT
Comment on attachment 156750 [details]

Pleas don't add any additonal def files. I'm already getting JSC.dll built without def files, only with export macros at bug 76257. Maybe you can help me in creating a patch for the last remaining pice: The windows build system. I only build with CMake and don't have a working one with VS2005+cygwin.
Comment 3 Alex Christensen 2012-08-06 15:16:11 PDT
If it compiles without the def files, why do we have any def files?  People are still making changes to them.  Why not remove them completely?  If they are used and people are making changes them, they should be making changes to the 64 bit def files, too.

(In reply to comment #2)