WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
93291
adding windows 64-bit definition files for JavaScriptCore and WebKit2CFLite
https://bugs.webkit.org/show_bug.cgi?id=93291
Summary
adding windows 64-bit definition files for JavaScriptCore and WebKit2CFLite
Alex Christensen
Reported
2012-08-06 13:01:33 PDT
I changed all the symbols to their 64-bit counterparts (no trivial task) and think it ought to be included in the repository so nobody else has to do it, and so that it can be maintained by the community.
https://github.com/achristensen07/webkit64prep
Attachments
Patch
(40.94 KB, patch)
2012-08-06 13:05 PDT
,
Alex Christensen
paroga
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2012-08-06 13:05:32 PDT
Created
attachment 156750
[details]
Patch
Patrick R. Gansterer
Comment 2
2012-08-06 14:58:57 PDT
Comment on
attachment 156750
[details]
Patch Pleas don't add any additonal def files. I'm already getting JSC.dll built without def files, only with export macros at
bug 76257
. Maybe you can help me in creating a patch for the last remaining pice: The windows build system. I only build with CMake and don't have a working one with VS2005+cygwin.
Alex Christensen
Comment 3
2012-08-06 15:16:11 PDT
If it compiles without the def files, why do we have any def files? People are still making changes to them. Why not remove them completely? If they are used and people are making changes them, they should be making changes to the 64 bit def files, too. (In reply to
comment #2
)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug