Bug 93232 – Remove unused png files from platform/chromium-linux/fast/css/variables

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Hayato Ito]

Png files in platform/chromium-linux/fast/css/variables are not used.

I guess these files should have been removed in https://bugs.webkit.org/show_bug.cgi?id=49483.

I am not sure what policy WebKit project has for such garbaged expectation files.
At least, a test runner complains about fast/css/variables/fast/css/variables/colors-test.html like:

> fast/css/variables/fast/css/variables/colors-test.html. is a reftest, but has an unused expectation file. Please remove ...<path_to>/WebKit/LayoutTests/platform/chromium-linux/fast/css
/variables/colors-test-expected.png.

[Hayato Ito]

Created attachment 156620 [details]
Remove unused png files

[Hayato Ito]

It'd be nice that we have a tool that cleans up such garbaged expectation files.

If not, we should file a bug to have a tool so that we can clean up periodically.

[Tony Chang]

Comment on attachment 156620 [details]
Remove unused png files

These are all ref-tests, right?  Luke might know what happened.

[Hayato Ito]

One of them (css/variables/colors-test.html) is a reftest, but I guess this is by accident.

Enabling tests for css variables for chromium just revealed these garbaged png files by having the reftest with the same name..

(In reply to comment #3)
> (From update of attachment 156620 [details])
> These are all ref-tests, right?  Luke might know what happened.

[WebKit Review Bot]

Comment on attachment 156620 [details]
Remove unused png files

Clearing flags on attachment: 156620

Committed r124748: <http://trac.webkit.org/changeset/124748>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.