Bug 93232 - Remove unused png files from platform/chromium-linux/fast/css/variables
Summary: Remove unused png files from platform/chromium-linux/fast/css/variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-06 01:28 PDT by Hayato Ito
Modified: 2012-08-06 03:18 PDT (History)
5 users (show)

See Also:


Attachments
Remove unused png files (80.83 KB, patch)
2012-08-06 01:32 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-08-06 01:28:37 PDT
Png files in platform/chromium-linux/fast/css/variables are not used.

I guess these files should have been removed in https://bugs.webkit.org/show_bug.cgi?id=49483.

I am not sure what policy WebKit project has for such garbaged expectation files.
At least, a test runner complains about fast/css/variables/fast/css/variables/colors-test.html like:

> fast/css/variables/fast/css/variables/colors-test.html. is a reftest, but has an unused expectation file. Please remove ...<path_to>/WebKit/LayoutTests/platform/chromium-linux/fast/css
/variables/colors-test-expected.png.
Comment 1 Hayato Ito 2012-08-06 01:32:35 PDT
Created attachment 156620 [details]
Remove unused png files
Comment 2 Hayato Ito 2012-08-06 01:35:50 PDT
It'd be nice that we have a tool that cleans up such garbaged expectation files.

If not, we should file a bug to have a tool so that we can clean up periodically.
Comment 3 Tony Chang 2012-08-06 02:12:46 PDT
Comment on attachment 156620 [details]
Remove unused png files

These are all ref-tests, right?  Luke might know what happened.
Comment 4 Hayato Ito 2012-08-06 02:21:48 PDT
One of them (css/variables/colors-test.html) is a reftest, but I guess this is by accident.

Enabling tests for css variables for chromium just revealed these garbaged png files by having the reftest with the same name..

(In reply to comment #3)
> (From update of attachment 156620 [details])
> These are all ref-tests, right?  Luke might know what happened.
Comment 5 WebKit Review Bot 2012-08-06 03:18:06 PDT
Comment on attachment 156620 [details]
Remove unused png files

Clearing flags on attachment: 156620

Committed r124748: <http://trac.webkit.org/changeset/124748>
Comment 6 WebKit Review Bot 2012-08-06 03:18:10 PDT
All reviewed patches have been landed.  Closing bug.