Bug 49483 - Remove CSS Variable support
Summary: Remove CSS Variable support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 16:20 PST by Alexey Proskuryakov
Modified: 2010-11-16 10:58 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (292.11 KB, patch)
2010-11-12 16:23 PST, Alexey Proskuryakov
hyatt: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-11-12 16:20:49 PST
It's been disabled for a long time, and doesn't seem to be gaining much traction.
Comment 1 Alexey Proskuryakov 2010-11-12 16:23:43 PST
Created attachment 73789 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2010-11-12 16:41:57 PST
I'm not sure about some code in CSSParserValues and CSSPrimitiveValue which Hyatt added at the same time as CSS Variables. It seems to be still used (at least partially), but maybe it's too complicated for what we need now?
Comment 3 Peter Beverloo 2010-11-13 02:41:13 PST
You might want to take note of bug 46594, filed not too long ago, which talks about reviving the implementation.
Comment 4 Dimitri Glazkov (Google) 2010-11-13 09:43:38 PST
(In reply to comment #3)
> You might want to take note of bug 46594, filed not too long ago, which talks about reviving the implementation.

Yup, I am very much interested in keeping and improving CSS variables. From talking with dhyatt, he is too.
Comment 5 Alexey Proskuryakov 2010-11-13 11:05:51 PST
> Yup, I am very much interested in keeping and improving CSS variables. 

I unsuccessfully tried to reach you on IRC yesterday, and it's a mistake on my part that I didn't CC you. 

> From talking with dhyatt, he is too.

Hyatt gave me a green light to remove the code yesterday. The problem is that variables greatly complicate ownership model of CSSOM objects, and I'd like to get them out of the way while straightening it up.

Also, my understanding was that CSS variables did't have much chance of going anywhere beyond WebKit, according to stated positions of other vendors and CSS working group members. I haven't participated in any of these discussions though, so I may be way off.
Comment 6 Dimitri Glazkov (Google) 2010-11-14 18:20:43 PST
(In reply to comment #5)
> > Yup, I am very much interested in keeping and improving CSS variables. 
> 
> I unsuccessfully tried to reach you on IRC yesterday, and it's a mistake on my part that I didn't CC you. 
> 
> > From talking with dhyatt, he is too.
> 
> Hyatt gave me a green light to remove the code yesterday. The problem is that variables greatly complicate ownership model of CSSOM objects, and I'd like to get them out of the way while straightening it up.
> 
> Also, my understanding was that CSS variables did't have much chance of going anywhere beyond WebKit, according to stated positions of other vendors and CSS working group members. I haven't participated in any of these discussions though, so I may be way off.

I don't mind yanking the code for now, especially if that helps refactoring. But I still want to bring them back and will work hard to clear any non-technical hurdles around it. And to be clear, this vendor really wants it implemented! :)
Comment 7 WebKit Commit Bot 2010-11-15 18:44:22 PST
Comment on attachment 73789 [details]
proposed patch

Rejecting patch 73789 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73789]" exit_code: 2
Last 500 characters of output:
'LayoutTests/platform/mac/fast/css/variables/alternate-syntax/variable-iteration-test-expected.png'
patching file LayoutTests/platform/mac/fast/css/variables/alternate-syntax/variable-iteration-test-expected.txt
rm 'LayoutTests/platform/mac/fast/css/variables/alternate-syntax/variable-iteration-test-expected.txt'
patching file LayoutTests/platform/qt/Skipped

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6083003
Comment 8 Alexey Proskuryakov 2010-11-16 10:26:57 PST
Committed <http://trac.webkit.org/changeset/72116>.
Comment 9 Alexey Proskuryakov 2010-11-16 10:58:55 PST
Windows build fix <http://trac.webkit.org/changeset/72121>.