RESOLVED FIXED Bug 93227
Chromium-Mac: Use the default locale only if the browser locale matches to it 
https://bugs.webkit.org/show_bug.cgi?id=93227
Summary Chromium-Mac: Use the default locale only if the browser locale matches to it
Kent Tamura
Reported 2012-08-05 23:26:35 PDT
OSX version of Bug 93083.
Attachments
Patch (3.49 KB, patch)
2012-08-06 00:05 PDT, Kent Tamura 		morrita: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-08-06 00:05:34 PDT
Created attachment 156609 [details] Patch
Kent Tamura
Comment 2 2012-08-06 02:48:54 PDT
Update the summary to avoid unexpected Gmail threading.
Hajime Morrita
Comment 3 2012-08-06 18:50:43 PDT
Comment on attachment 156609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review > Source/WebCore/platform/text/mac/LocaleMac.mm:92 > + String browserLanguage = languageFromLocale(defaultLanguage()); Passing defulat"Language" to languageFrom"Locale"(). is this right?
Kent Tamura
Comment 4 2012-08-06 18:56:21 PDT
Comment on attachment 156609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review >> Source/WebCore/platform/text/mac/LocaleMac.mm:92 >> + String browserLanguage = languageFromLocale(defaultLanguage()); > > Passing defulat"Language" to languageFrom"Locale"(). is this right? Unfortunately, it's right. defaultLanguage() returns a locale identifier like "en-US" as well as a language identifier like "en".
Kent Tamura
Comment 5 2012-08-06 19:01:43 PDT
Committed r124834: <http://trac.webkit.org/changeset/124834>
Note You need to log in before you can comment on or make changes to this bug.