Bug 93227 - Chromium-Mac: Use the default locale only if the browser locale matches to it
Summary: Chromium-Mac: Use the default locale only if the browser locale matches to it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-05 23:26 PDT by Kent Tamura
Modified: 2012-08-06 19:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2012-08-06 00:05 PDT, Kent Tamura 		morrita: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-08-05 23:26:35 PDT 
OSX version of Bug 93083.
Comment 1 Kent Tamura 2012-08-06 00:05:34 PDT 
Created attachment 156609 [details]
Patch
Comment 2 Kent Tamura 2012-08-06 02:48:54 PDT 
Update the summary to avoid unexpected Gmail threading.
Comment 3 Hajime Morrita 2012-08-06 18:50:43 PDT 
Comment on attachment 156609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review

> Source/WebCore/platform/text/mac/LocaleMac.mm:92
> +    String browserLanguage = languageFromLocale(defaultLanguage());

Passing defulat"Language" to languageFrom"Locale"(). is this right?
Comment 4 Kent Tamura 2012-08-06 18:56:21 PDT 
Comment on attachment 156609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review

>> Source/WebCore/platform/text/mac/LocaleMac.mm:92
>> +    String browserLanguage = languageFromLocale(defaultLanguage());
> 
> Passing defulat"Language" to languageFrom"Locale"(). is this right?

Unfortunately, it's right.  defaultLanguage() returns a locale identifier like "en-US" as well as a language identifier like "en".
Comment 5 Kent Tamura 2012-08-06 19:01:43 PDT 
Committed r124834: <http://trac.webkit.org/changeset/124834>