Bug 93083 – [Chromium-win] Use the default locale only if the browser locale matches to it

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

http://code.google.com/p/chromium/issues/detail?id=139337

For a calendar picker, we have used month names and day-of-week names obtained from the OS default locale. However, the year-month format and [Today] [Clear] labels are decided with the browser locale.

So, if the OS default locale is en-US and the browser locale is ja-JP,
  - Month names and DOW names are English
  - [Today] [Clear] labels are Japanese, and year-month format is for ja-JP.
    The calendar picker shows '2012年 August' (OOPS!)

[Kent Tamura]

Created attachment 156305 [details]
Patch

[Hajime Morrita]

Comment on attachment 156305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156305&action=review

> Source/WebCore/platform/text/LocaleWin.cpp:81
> -    static LocaleWin* currentLocale = LocaleWin::create(LOCALE_USER_DEFAULT).leakPtr();
> +    static LocaleWin* currentLocale;

I'd extract LCID lookup part to a function, then we easily do early return and the code will look simpler.

[Kent Tamura]

Created attachment 156315 [details]
Patch 2

make a function

[Kent Tamura]

Comment on attachment 156305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156305&action=review

>> Source/WebCore/platform/text/LocaleWin.cpp:81
>> +    static LocaleWin* currentLocale;
> 
> I'd extract LCID lookup part to a function, then we easily do early return and the code will look simpler.

Indeed.  Updated the patch.

[Kent Tamura]

Committed r124721: <http://trac.webkit.org/changeset/124721>