Bug 93085 – [Chromium-win] Use system locale for number representation

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

In Chromium-win, we use LocaleICU for <input type=number> localization. We should apply Windows locale system instead.

[Kent Tamura]

Created attachment 156594 [details]
Patch

[Kentaro Hara]

Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

morrita-san: I'm not familiar with the implementation... Would you take a look?

> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385
> +    testNumbers(ArabicEG);

Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).

[Kent Tamura]

Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

>> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385
>> +    testNumbers(ArabicEG);
> 
> Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).

They are covered by the testNumberIsReversive calls with extra shouldHave argument.

[Hajime Morrita]

Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

> Source/WebCore/platform/text/LocaleWin.cpp:756
> +        negativeSuffix = negativeSign;

Is this fall-through intentional? If so, please add a comment.

> Source/WebCore/platform/text/LocaleWin.cpp:758
> +        negativeSuffix = " " + negativeSign;

Ditto.

[Kent Tamura]

Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

>> Source/WebCore/platform/text/LocaleWin.cpp:756
>> +        negativeSuffix = negativeSign;
> 
> Is this fall-through intentional? If so, please add a comment.

oh, it's a real bug.

[Kent Tamura]

Created attachment 156596 [details]
Patch 2

Add breaks

[Kent Tamura]

Committed r124735: <http://trac.webkit.org/changeset/124735>