WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93085
[Chromium-win] Use system locale for number representation
https://bugs.webkit.org/show_bug.cgi?id=93085
Summary
[Chromium-win] Use system locale for number representation
Kent Tamura
Reported
2012-08-03 03:37:59 PDT
In Chromium-win, we use LocaleICU for <input type=number> localization. We should apply Windows locale system instead.
Attachments
Patch
(16.67 KB, patch)
2012-08-05 22:01 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Patch 2
(16.72 KB, patch)
2012-08-05 22:37 PDT
,
Kent Tamura
morrita
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2012-08-05 22:01:39 PDT
Created
attachment 156594
[details]
Patch
Kentaro Hara
Comment 2
2012-08-05 22:15:03 PDT
Comment on
attachment 156594
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=156594&action=review
morrita-san: I'm not familiar with the implementation... Would you take a look?
> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385 > + testNumbers(ArabicEG);
Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).
Kent Tamura
Comment 3
2012-08-05 22:17:06 PDT
Comment on
attachment 156594
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=156594&action=review
>> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385 >> + testNumbers(ArabicEG); > > Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).
They are covered by the testNumberIsReversive calls with extra shouldHave argument.
Hajime Morrita
Comment 4
2012-08-05 22:18:47 PDT
Comment on
attachment 156594
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=156594&action=review
> Source/WebCore/platform/text/LocaleWin.cpp:756 > + negativeSuffix = negativeSign;
Is this fall-through intentional? If so, please add a comment.
> Source/WebCore/platform/text/LocaleWin.cpp:758 > + negativeSuffix = " " + negativeSign;
Ditto.
Kent Tamura
Comment 5
2012-08-05 22:25:00 PDT
Comment on
attachment 156594
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=156594&action=review
>> Source/WebCore/platform/text/LocaleWin.cpp:756 >> + negativeSuffix = negativeSign; > > Is this fall-through intentional? If so, please add a comment.
oh, it's a real bug.
Kent Tamura
Comment 6
2012-08-05 22:37:46 PDT
Created
attachment 156596
[details]
Patch 2 Add breaks
Kent Tamura
Comment 7
2012-08-05 23:40:07 PDT
Committed
r124735
: <
http://trac.webkit.org/changeset/124735
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug