Bug 93085 - [Chromium-win] Use system locale for number representation
Summary: [Chromium-win] Use system locale for number representation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 92976 93083
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-03 03:37 PDT by Kent Tamura
Modified: 2012-08-05 23:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (16.67 KB, patch)
2012-08-05 22:01 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (16.72 KB, patch)
2012-08-05 22:37 PDT, Kent Tamura 		morrita: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-08-03 03:37:59 PDT 
In Chromium-win, we use LocaleICU for <input type=number> localization. We should apply Windows locale system instead.
Comment 1 Kent Tamura 2012-08-05 22:01:39 PDT 
Created attachment 156594 [details]
Patch
Comment 2 Kentaro Hara 2012-08-05 22:15:03 PDT 
Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

morrita-san: I'm not familiar with the implementation... Would you take a look?

> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385
> +    testNumbers(ArabicEG);

Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).
Comment 3 Kent Tamura 2012-08-05 22:17:06 PDT 
Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

>> Source/WebKit/chromium/tests/LocaleWinTest.cpp:385
>> +    testNumbers(ArabicEG);
> 
> Let's add testNumbers(FrenchFR) and testNumbers(EnglishUS).

They are covered by the testNumberIsReversive calls with extra shouldHave argument.
Comment 4 Hajime Morrita 2012-08-05 22:18:47 PDT 
Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

> Source/WebCore/platform/text/LocaleWin.cpp:756
> +        negativeSuffix = negativeSign;

Is this fall-through intentional? If so, please add a comment.

> Source/WebCore/platform/text/LocaleWin.cpp:758
> +        negativeSuffix = " " + negativeSign;

Ditto.
Comment 5 Kent Tamura 2012-08-05 22:25:00 PDT 
Comment on attachment 156594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156594&action=review

>> Source/WebCore/platform/text/LocaleWin.cpp:756
>> +        negativeSuffix = negativeSign;
> 
> Is this fall-through intentional? If so, please add a comment.

oh, it's a real bug.
Comment 6 Kent Tamura 2012-08-05 22:37:46 PDT 
Created attachment 156596 [details]
Patch 2

Add breaks
Comment 7 Kent Tamura 2012-08-05 23:40:07 PDT 
Committed r124735: <http://trac.webkit.org/changeset/124735>