WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93109
Remove all usages of M_PI from WebCore
https://bugs.webkit.org/show_bug.cgi?id=93109
Summary
Remove all usages of M_PI from WebCore
Patrick R. Gansterer
Reported
2012-08-03 07:05:11 PDT
Remove all usages of M_PI from WebCore
Attachments
Patch
(7.68 KB, patch)
2012-08-03 07:08 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(8.15 KB, patch)
2012-09-18 22:57 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(8.15 KB, patch)
2012-09-19 05:16 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2012-08-03 07:08:26 PDT
Created
attachment 156363
[details]
Patch
Build Bot
Comment 2
2012-08-03 10:50:17 PDT
Comment on
attachment 156363
[details]
Patch
Attachment 156363
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13422867
Eric Seidel (no email)
Comment 3
2012-08-07 15:31:02 PDT
Comment on
attachment 156363
[details]
Patch Why? Looks like Mac didn't like this chnage, but otherwise I'm OK with it if the EWSes are.
Patrick R. Gansterer
Comment 4
2012-09-18 22:57:38 PDT
Created
attachment 164666
[details]
Patch
Build Bot
Comment 5
2012-09-18 23:05:33 PDT
Comment on
attachment 164666
[details]
Patch
Attachment 164666
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13900415
Patrick R. Gansterer
Comment 6
2012-09-19 05:16:56 PDT
Created
attachment 164721
[details]
Patch
Dirk Schulze
Comment 7
2012-09-19 07:38:12 PDT
Comment on
attachment 164721
[details]
Patch LGTM. r=me
WebKit Review Bot
Comment 8
2012-09-19 07:42:29 PDT
Comment on
attachment 164721
[details]
Patch Clearing flags on attachment: 164721 Committed
r129005
: <
http://trac.webkit.org/changeset/129005
>
WebKit Review Bot
Comment 9
2012-09-19 07:42:33 PDT
All reviewed patches have been landed. Closing bug.
Alberto Garcia
Comment 10
2013-10-09 15:13:08 PDT
***
Bug 52197
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug