Bug 52197 - Use definition of PI from MathExtras.h
Summary: Use definition of PI from MathExtras.h
Status: RESOLVED DUPLICATE of bug 93109
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 22:46 PST by Carl Lobo
Modified: 2013-10-09 15:13 PDT (History)
1 user (show)

See Also:

Attachments
This patch uses the standard definitions of PI from MathExtras.h (3.48 KB, patch)
2011-01-10 22:47 PST, Carl Lobo 		eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Lobo 2011-01-10 22:46:24 PST 
Removed redefinition of M_PI and replaced it with piDouble or piFloat as appropriate.
Comment 1 Carl Lobo 2011-01-10 22:47:37 PST 
Created attachment 78497 [details]
This patch uses the standard definitions of PI from MathExtras.h
Comment 2 Eric Seidel (no email) 2011-01-11 03:03:06 PST 
Comment on attachment 78497 [details]
This patch uses the standard definitions of PI from MathExtras.h

View in context: https://bugs.webkit.org/attachment.cgi?id=78497&action=review

Looks great.  But we need to fix the ChangeLog first or the commit-queue will fail to process it.

> Source/WebCore/ChangeLog:7
> +        Need a short description and bug URL (OOPS!)

This will prevent the cq from being able to land this.  the -b option to prepare-ChangeLog will fill this in automatically for you, or just using "webkit-patch upload" will fill it in too.
Comment 3 Adam Barth 2011-06-17 23:01:49 PDT 
Comment on attachment 78497 [details]
This patch uses the standard definitions of PI from MathExtras.h

Please upload a new patch for the commit-queue.
Comment 4 Alberto Garcia 2013-10-09 15:13:08 PDT 

*** This bug has been marked as a duplicate of bug 93109 ***