Bug 93006 - [Chromium] Layout Tests tables/mozilla/bugs/bug27038*.html are failing
Summary: [Chromium] Layout Tests tables/mozilla/bugs/bug27038*.html are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-02 10:25 PDT by Alexander Pavlov (apavlov)
Modified: 2012-09-08 08:24 PDT (History)
1 user (show)

See Also:


Attachments
Patch for landing (112.18 KB, patch)
2012-09-08 08:02 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-08-02 10:25:25 PDT
Bug 37244 patch fixed the tests

tables/mozilla/bugs/bug27038-1.html
tables/mozilla/bugs/bug27038-2.html

but they were broken once again some time ago, which went unnoticed due to the fact that their IMAGE+TEXT expectations had never been removed from the TestExpectations file.
Comment 1 Julien Chaffraix 2012-09-08 07:58:08 PDT
The history of those 2 lines is a bit more complex. bug 37244 did the proper rebaselining. However part of it was rolled out as part of bug 81826 and the approach taken for this bug was to disable the tests on all platforms until I come around and rebaseline them.
Unfortunately I wrongly copied the TestExpectations entry from other ports that hadn't rebaselined them thus the Chromium entries are pointing at bug 37244 and not bug 81826.

The new baselines are expected so I will just rebaseline the tests.
Comment 2 Julien Chaffraix 2012-09-08 08:02:37 PDT
Created attachment 162958 [details]
Patch for landing
Comment 3 WebKit Review Bot 2012-09-08 08:24:25 PDT
Comment on attachment 162958 [details]
Patch for landing

Clearing flags on attachment: 162958

Committed r127971: <http://trac.webkit.org/changeset/127971>
Comment 4 WebKit Review Bot 2012-09-08 08:24:28 PDT
All reviewed patches have been landed.  Closing bug.