Bug 81826 – REGRESSION(107971): Google Voice contact list is broken in WebKit due to badly allocating the extra height

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

r107971 made an unneeded change to the way we allocate extra logical height in WebKit. I thought this change was neutral (from the ChangeLog):

This is neither a progression nor a regression. We are not doing the right
thing as we don't distribute the extra logical height evenly over our sections.
Now we give the extra height to the <thead> (first section) instead of the <tbody>.

But it looks like some web content was relying on our broken behavior. The real fix would be to fix our super broken extra logical height distribution algorithm which is tracked by bug 81824.

Downstream: http://code.google.com/p/chromium/issues/detail?id=114939

[Julien Chaffraix]

Looking again, if we roll out part of r107971, it's likely LayoutTests/fast/table/double-height-table-no-tbody.html would need to be rewritten as it assumed a non-broken distribution.

The Google voice issue was solved with a redesign which makes it less important and I haven't heard of any other report about that for now.

[Julien Chaffraix]

Created attachment 133424 [details]
Revert the unneeded change to our extra logical height distribution algorithm.

[WebKit Review Bot]

Comment on attachment 133424 [details]
Revert the unneeded change to our extra logical height distribution algorithm.

Attachment 133424 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12117474

New failing tests:
tables/mozilla/bugs/bug27038-2.html
tables/mozilla/bugs/bug27038-1.html

[Julien Chaffraix]

Created attachment 133491 [details]
Updated the chromium entries that was wrong and tweaked more platforms' Skipped files.

[Julien Chaffraix]

Comment on attachment 133491 [details]
Updated the chromium entries that was wrong and tweaked more platforms' Skipped files.

Thanks Tony!

[WebKit Review Bot]

Comment on attachment 133491 [details]
Updated the chromium entries that was wrong and tweaked more platforms' Skipped files.

Clearing flags on attachment: 133491

Committed r111882: <http://trac.webkit.org/changeset/111882>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

*** Bug 81620 has been marked as a duplicate of this bug. ***