Bug 92895 - [Qt][WK2] There's no way to test the gesture tap on WTR
Summary: [Qt][WK2] There's no way to test the gesture tap on WTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hugo Parente Lima
URL:
Keywords:
Depends on:
Blocks: 66173 91012
  Show dependency tree / graph
 
Reported: 2012-08-01 12:03 PDT by Hugo Parente Lima
Modified: 2012-08-03 10:21 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2012-08-02 15:36 PDT, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2012-08-01 12:03:13 PDT 
There's no way to test the gesture tap on WTR because the code on QtWebPageEventHandler::doneWithTouchEvent relies on a instance of QtViewportHandler and such instance doesn't exist because WTR runs on "desktop mode".
Comment 1 Hugo Parente Lima 2012-08-02 15:36:01 PDT 
Created attachment 156184 [details]
Patch
Comment 2 Andras Becsi 2012-08-03 08:47:12 PDT 
As far as I remember componentComplete is only triggered in QML, so in C++ unless WTR creates a WebView component dinamically this codepath won't be triggered so the viewport handler will still be null there, but I might be wrong.
Comment 3 WebKit Review Bot 2012-08-03 10:21:34 PDT 
Comment on attachment 156184 [details]
Patch

Clearing flags on attachment: 156184

Committed r124625: <http://trac.webkit.org/changeset/124625>
Comment 4 WebKit Review Bot 2012-08-03 10:21:38 PDT 
All reviewed patches have been landed.  Closing bug.