WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92895
[Qt][WK2] There's no way to test the gesture tap on WTR
https://bugs.webkit.org/show_bug.cgi?id=92895
Summary
[Qt][WK2] There's no way to test the gesture tap on WTR
Hugo Parente Lima
Reported
2012-08-01 12:03:13 PDT
There's no way to test the gesture tap on WTR because the code on QtWebPageEventHandler::doneWithTouchEvent relies on a instance of QtViewportHandler and such instance doesn't exist because WTR runs on "desktop mode".
Attachments
Patch
(5.29 KB, patch)
2012-08-02 15:36 PDT
,
Hugo Parente Lima
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1
2012-08-02 15:36:01 PDT
Created
attachment 156184
[details]
Patch
Andras Becsi
Comment 2
2012-08-03 08:47:12 PDT
As far as I remember componentComplete is only triggered in QML, so in C++ unless WTR creates a WebView component dinamically this codepath won't be triggered so the viewport handler will still be null there, but I might be wrong.
WebKit Review Bot
Comment 3
2012-08-03 10:21:34 PDT
Comment on
attachment 156184
[details]
Patch Clearing flags on attachment: 156184 Committed
r124625
: <
http://trac.webkit.org/changeset/124625
>
WebKit Review Bot
Comment 4
2012-08-03 10:21:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug