r92997 added new eventSender method: gestureTap. Qt should implement this feature.
Created attachment 103830 [details] fix
The fast/event/touch tests are already skipped in other platforms (e.g. win, mac, gtk)
Comment on attachment 103830 [details] fix I'm adding the test to the Qt's skipped list for now. This patch isn't going to fix this bug because it doesn't actually implement the eventSender method.
The test skipped in http://trac.webkit.org/changeset/93006.
Created attachment 128237 [details] Patch
Comment on attachment 128237 [details] Patch Clearing flags on attachment: 128237 Committed r108577: <http://trac.webkit.org/changeset/108577>
All reviewed patches have been landed. Closing bug.
The patch did not implement the tap gesture in a functional way, and I am not sure we want to implement it since it is completely absent from the WebKitTestRunner.
Created attachment 164729 [details] Patch
Comment on attachment 164729 [details] Patch Clearing flags on attachment: 164729 Committed r129102: <http://trac.webkit.org/changeset/129102>
The implemenatation lacked handling of the GestureEvent in WebKit code. I missed this for the second time, because the default expected result of the test-case is actually a fail.
Created attachment 165132 [details] Patch2
Attachment 165132 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/qt/Api/qwebpage.cpp:98: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/Api/qwebpage.cpp:136: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 165132 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review r=me but needs #include order fix before landing I suppose :) > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322 > + m_position = event->widget()->mapFromGlobal(globalPos.toPoint()); With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :)
(In reply to comment #15) > (From update of attachment 165132 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review > > r=me but needs #include order fix before landing I suppose :) > > > Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322 > > + m_position = event->widget()->mapFromGlobal(globalPos.toPoint()); > > With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great if the widget local position could be provided as a parameter from outside to reduce the amount of widget code here :) But wouldn't QtWebKit(1) be in QtWebKitWidgets, and therefore allowed to depend on Widget code?
Committed in r132052
Comment on attachment 165132 [details] Patch2 Clearing flags