Bug 92845 – Regression(r124135): nrwt: --verbose logging does not work right on windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Thiago Marcos P. Santos]

[0/1552] webkit2.messages_unittest.ParsingTest.test_receiver
[945/1552] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_verbose erred:
  Traceback (most recent call last):
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 934, in test_verbose
      _, _, err, _ = logging_run(['--verbose', '--fully-parallel', '--child-processes', '2', 'passes/text.html', 'passes/image.html'], tests_included=True)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 110, in logging_run
      res, buildbot_output, regular_output = run_and_capture(port_obj, options, parsed_args, shared_port)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 124, in run_and_capture
      regular_output=regular_output)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run
      unexpected_result_count = manager.run(args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 725, in run
      interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_names, result_summary, int(self._options.child_processes))
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 638, in _run_tests
      pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run
      self.wait()
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 130, in wait
      self._loop(block=True)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 182, in _loop
      method(message.src, *message.args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 161, in _handle_worker_exception
      raise WorkerException(str(exception_value))
  WorkerException: [Errno 2] No such file or directory: '/tmp/layout-test-results/tests_run1.txt'
  
Ran 1552 tests in 6.899s
FAILED (failures=0, errors=1)

[Thiago Marcos P. Santos]

Created attachment 155768 [details]
Patch

[Thiago Marcos P. Santos]

(In reply to comment #1)
> Created an attachment (id=155768) [details]
> Patch

I wrote some details about why this test is failing on the changelog. If you cannot reproduce the failure is probably because you have the directory /tmp/layout-test-results/ created at your system.

[Dirk Pranke]

Comment on attachment 155768 [details]
Patch

Nope, this tests the opposite of what it needs to test (which is that --verbose propagates to the subprocess). I should add a comment to that effect.

We'll have to fix the results_dir problem differently.

[Dirk Pranke]

One workaround is to create the results_directory using fs.maybe_make_directory() right before we create the file.

This isn't a good solution because the test shouldn't be modifying the filesystem, but it would work.

Another solution is to just disable the test for now (e.g., change the name to disabled_test_verbose).

[Thiago Marcos P. Santos]

(In reply to comment #4)
> One workaround is to create the results_directory using fs.maybe_make_directory() right before we create the file.
> 
> This isn't a good solution because the test shouldn't be modifying the filesystem, but it would work.
> 
> Another solution is to just disable the test for now (e.g., change the name to disabled_test_verbose).

In this case I agree, it wasn't really clear to me what was being tested. Judging by the original patch I thought it was just validating --verbose (that was previously not working on Windows).

Going to update the patch. Thanks for reviewing.

[Thiago Marcos P. Santos]

Created attachment 155820 [details]
Patch

Creating the folder might work for *nix but since it relies on the default_results_directory() provided by the MockPort, it wont scale to Windows. This patch disables the test until we find a better solution.

[WebKit Review Bot]

Comment on attachment 155820 [details]
Patch

Clearing flags on attachment: 155820

Committed r124344: <http://trac.webkit.org/changeset/124344>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

re-enabling the test in bug 92894.