Bug 92673 - nrwt: --verbose logging does not work right on windows
Summary: nrwt: --verbose logging does not work right on windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
Depends on: 92845
  Show dependency treegraph
Reported: 2012-07-30 13:22 PDT by Dirk Pranke
Modified: 2012-08-01 03:14 PDT (History)
6 users (show)

See Also:

Patch (5.13 KB, patch)
2012-07-30 14:05 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (2.10 KB, patch)
2012-07-30 14:51 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff
remove wontfix from add_skipped_tests, expectation_for_skipped_tests (21.61 KB, patch)
2012-07-30 16:45 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-30 13:22:06 PDT
nrwt: --verbose logging does not work right on windows
Comment 1 Dirk Pranke 2012-07-30 14:05:30 PDT
Created attachment 155357 [details]
Comment 2 Dirk Pranke 2012-07-30 14:06:39 PDT
Comment on attachment 155357 [details]

landing as an unreviewed build fix so I can get output from the bot ... I will land a revised patch w/ a test later.
Comment 3 Dirk Pranke 2012-07-30 14:07:59 PDT
Committed r124090: <http://trac.webkit.org/changeset/124090>
Comment 4 Dirk Pranke 2012-07-30 14:51:42 PDT
Reopening to attach new patch.
Comment 5 Dirk Pranke 2012-07-30 14:51:44 PDT
Created attachment 155370 [details]
Comment 6 Dirk Pranke 2012-07-30 14:55:37 PDT
you'll probably want to look at both patches ... the second is just the test for the first. it turns out it was tricky to write because outputcapture doesn't play nicely with multiprocess tests using the test port.
Comment 7 Dirk Pranke 2012-07-30 16:45:58 PDT
Created attachment 155398 [details]
remove wontfix from add_skipped_tests, expectation_for_skipped_tests
Comment 8 Dirk Pranke 2012-07-30 16:49:39 PDT
Comment on attachment 155398 [details]
remove wontfix from add_skipped_tests, expectation_for_skipped_tests

ignore, wrong bug.
Comment 9 Dirk Pranke 2012-07-31 12:10:02 PDT
Committed r124235: <http://trac.webkit.org/changeset/124235>
Comment 10 Thiago Marcos P. Santos 2012-07-31 23:40:59 PDT
This patch caused a regression on the test-webkitpy. I'm going to open a bug for fixing it.

[945/1552] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_verbose erred:
  Traceback (most recent call last):
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 934, in test_verbose
      _, _, err, _ = logging_run(['--verbose', '--fully-parallel', '--child-processes', '2', 'passes/text.html', 'passes/image.html'], tests_included=True)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 110, in logging_run
      res, buildbot_output, regular_output = run_and_capture(port_obj, options, parsed_args, shared_port)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 124, in run_and_capture
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run
      unexpected_result_count = manager.run(args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 725, in run
      interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_names, result_summary, int(self._options.child_processes))
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 638, in _run_tests
      pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 130, in wait
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 182, in _loop
      method(message.src, *message.args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 161, in _handle_worker_exception
      raise WorkerException(str(exception_value))
  WorkerException: [Errno 2] No such file or directory: '/tmp/layout-test-results/tests_run1.txt'
Ran 1552 tests in 6.899s
FAILED (failures=0, errors=1)
Comment 11 Thiago Marcos P. Santos 2012-08-01 03:14:26 PDT
Fix pending review at bug 92845.