Bug 92673 – nrwt: --verbose logging does not work right on windows

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: --verbose logging does not work right on windows

[Dirk Pranke]

Created attachment 155357 [details]
Patch

[Dirk Pranke]

Comment on attachment 155357 [details]
Patch

landing as an unreviewed build fix so I can get output from the bot ... I will land a revised patch w/ a test later.

[Dirk Pranke]

Committed r124090: <http://trac.webkit.org/changeset/124090>

[Dirk Pranke]

Reopening to attach new patch.

[Dirk Pranke]

Created attachment 155370 [details]
Patch

[Dirk Pranke]

you'll probably want to look at both patches ... the second is just the test for the first. it turns out it was tricky to write because outputcapture doesn't play nicely with multiprocess tests using the test port.

[Dirk Pranke]

Created attachment 155398 [details]
remove wontfix from add_skipped_tests, expectation_for_skipped_tests

[Dirk Pranke]

Comment on attachment 155398 [details]
remove wontfix from add_skipped_tests, expectation_for_skipped_tests

ignore, wrong bug.

[Dirk Pranke]

Committed r124235: <http://trac.webkit.org/changeset/124235>

[Thiago Marcos P. Santos]

This patch caused a regression on the test-webkitpy. I'm going to open a bug for fixing it.

[945/1552] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_verbose erred:
  Traceback (most recent call last):
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 934, in test_verbose
      _, _, err, _ = logging_run(['--verbose', '--fully-parallel', '--child-processes', '2', 'passes/text.html', 'passes/image.html'], tests_included=True)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 110, in logging_run
      res, buildbot_output, regular_output = run_and_capture(port_obj, options, parsed_args, shared_port)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 124, in run_and_capture
      regular_output=regular_output)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run
      unexpected_result_count = manager.run(args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 725, in run
      interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_names, result_summary, int(self._options.child_processes))
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 638, in _run_tests
      pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run
      self.wait()
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 130, in wait
      self._loop(block=True)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 182, in _loop
      method(message.src, *message.args)
    File "/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/Scripts/webkitpy/common/message_pool.py", line 161, in _handle_worker_exception
      raise WorkerException(str(exception_value))
  WorkerException: [Errno 2] No such file or directory: '/tmp/layout-test-results/tests_run1.txt'
  
Ran 1552 tests in 6.899s
FAILED (failures=0, errors=1)

[Thiago Marcos P. Santos]

Fix pending review at bug 92845.