WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92760
Get rid of "parser" type casts in CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=92760
Summary
Get rid of "parser" type casts in CSSGrammar.y
Alexander Pavlov (apavlov)
Reported
2012-07-31 08:28:19 PDT
The parser used to be non-typed, so it required casting to CSSParser (static_cast<CSSParser*>(parser)) all over the place.
Bug 92264
patch fixed this, so these casts are no longer needed.
Attachments
Patch
(39.00 KB, patch)
2012-07-31 10:59 PDT
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1
2012-07-31 10:59:16 PDT
Created
attachment 155585
[details]
Patch
Adam Barth
Comment 2
2012-07-31 11:54:12 PDT
Comment on
attachment 155585
[details]
Patch That's exciting. Thanks!
WebKit Review Bot
Comment 3
2012-07-31 12:21:28 PDT
Comment on
attachment 155585
[details]
Patch Rejecting
attachment 155585
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nflict in Tools/Scripts/webkitpy/layout_tests/controllers/manager.py Failed to merge in the changes. Patch failed at 0001 nrwt: --verbose logging does not work right on windows When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output:
http://queues.webkit.org/results/13400540
WebKit Review Bot
Comment 4
2012-07-31 12:50:16 PDT
Comment on
attachment 155585
[details]
Patch Clearing flags on attachment: 155585 Committed
r124241
: <
http://trac.webkit.org/changeset/124241
>
WebKit Review Bot
Comment 5
2012-07-31 12:50:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug