Bug 92760 - Get rid of "parser" type casts in CSSGrammar.y
Summary: Get rid of "parser" type casts in CSSGrammar.y
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexis Menard (darktears)
Depends on:
Reported: 2012-07-31 08:28 PDT by Alexander Pavlov (apavlov)
Modified: 2012-07-31 12:50 PDT (History)
6 users (show)

See Also:

Patch (39.00 KB, patch)
2012-07-31 10:59 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-07-31 08:28:19 PDT
The parser used to be non-typed, so it required casting to CSSParser (static_cast<CSSParser*>(parser)) all over the place. Bug 92264 patch fixed this, so these casts are no longer needed.
Comment 1 Alexis Menard (darktears) 2012-07-31 10:59:16 PDT
Created attachment 155585 [details]
Comment 2 Adam Barth 2012-07-31 11:54:12 PDT
Comment on attachment 155585 [details]

That's exciting.  Thanks!
Comment 3 WebKit Review Bot 2012-07-31 12:21:28 PDT
Comment on attachment 155585 [details]

Rejecting attachment 155585 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
nflict in Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
Failed to merge in the changes.
Patch failed at 0001 nrwt: --verbose logging does not work right on windows

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13400540
Comment 4 WebKit Review Bot 2012-07-31 12:50:16 PDT
Comment on attachment 155585 [details]

Clearing flags on attachment: 155585

Committed r124241: <http://trac.webkit.org/changeset/124241>
Comment 5 WebKit Review Bot 2012-07-31 12:50:20 PDT
All reviewed patches have been landed.  Closing bug.