Bug 92264 - Build fix with newer bison 2.6.
: Build fix with newer bison 2.6.
Status: RESOLVED FIXED
: WebKit
XML
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-07-25 10:07 PST by
Modified: 2012-07-30 15:18 PST (History)


Attachments
Patch (1.71 KB, patch)
2012-07-25 10:12 PST, Alexis Menard (darktears)
no flags Review Patch | Details | Formatted Diff | Diff
Patch (17.57 KB, patch)
2012-07-26 06:19 PST, Alexis Menard (darktears)
no flags Review Patch | Details | Formatted Diff | Diff
Patch (17.64 KB, patch)
2012-07-26 06:46 PST, Alexis Menard (darktears)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-07-25 10:07:55 PST
Build fix with GCC 4.7.1
------- Comment #1 From 2012-07-25 10:12:13 PST -------
Created an attachment (id=154381) [details]
Patch
------- Comment #2 From 2012-07-25 10:15:45 PST -------
*** Bug 91943 has been marked as a duplicate of this bug. ***
------- Comment #3 From 2012-07-25 10:16:40 PST -------
(In reply to comment #2)
> *** Bug 91943 has been marked as a duplicate of this bug. ***

According to the bug in fact the bison output is different.
------- Comment #4 From 2012-07-25 10:19:59 PST -------
(From update of attachment 154381 [details])
Clearing flags for now.
------- Comment #5 From 2012-07-25 13:12:31 PST -------
(From update of attachment 154381 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review

> Source/WebCore/ChangeLog:3
> +        Build fix with GCC 4.7.1

The bug title is different now.
------- Comment #6 From 2012-07-25 13:47:58 PST -------
(In reply to comment #5)
> (From update of attachment 154381 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Build fix with GCC 4.7.1
> 
> The bug title is different now.

I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf.
------- Comment #7 From 2012-07-25 13:49:24 PST -------
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 154381 [details] [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Build fix with GCC 4.7.1
> > 
> > The bug title is different now.
> 
> I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf.

sorry bison*
------- Comment #8 From 2012-07-25 23:32:51 PST -------
The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here.
------- Comment #9 From 2012-07-26 06:19:07 PST -------
Created an attachment (id=154637) [details]
Patch
------- Comment #10 From 2012-07-26 06:20:05 PST -------
(In reply to comment #9)
> Created an attachment (id=154637) [details] [details]
> Patch

Let's see EWS before asking for review. I'll give a shot on a Mac as EWS Mac is out of service for the moment.
------- Comment #11 From 2012-07-26 06:22:47 PST -------
Attachment 154637 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #12 From 2012-07-26 06:46:06 PST -------
Created an attachment (id=154643) [details]
Patch
------- Comment #13 From 2012-07-26 06:46:38 PST -------
(In reply to comment #8)
> The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here.

That's what the last patch is addressing.
------- Comment #14 From 2012-07-26 06:49:32 PST -------
Attachment 154643 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #15 From 2012-07-30 12:20:43 PST -------
Is someone going to commit this? :)
------- Comment #16 From 2012-07-30 15:00:51 PST -------
(From update of attachment 154643 [details])
Ok
------- Comment #17 From 2012-07-30 15:18:36 PST -------
(From update of attachment 154643 [details])
Clearing flags on attachment: 154643

Committed r124099: <http://trac.webkit.org/changeset/124099>
------- Comment #18 From 2012-07-30 15:18:42 PST -------
All reviewed patches have been landed.  Closing bug.