Bug 92264 – Build fix with newer bison 2.6.

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Alexis Menard (darktears)]

Build fix with GCC 4.7.1

[Alexis Menard (darktears)]

Created attachment 154381 [details]
Patch

[Alexis Menard (darktears)]

*** Bug 91943 has been marked as a duplicate of this bug. ***

[Alexis Menard (darktears)]

(In reply to comment #2)
> *** Bug 91943 has been marked as a duplicate of this bug. ***

According to the bug in fact the bison output is different.

[Alexis Menard (darktears)]

Comment on attachment 154381 [details]
Patch

Clearing flags for now.

[Rafael Brandao]

Comment on attachment 154381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review

> Source/WebCore/ChangeLog:3
> +        Build fix with GCC 4.7.1

The bug title is different now.

[Alexis Menard (darktears)]

(In reply to comment #5)
> (From update of attachment 154381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Build fix with GCC 4.7.1
> 
> The bug title is different now.

I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf.

[Alexis Menard (darktears)]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 154381 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Build fix with GCC 4.7.1
> > 
> > The bug title is different now.
> 
> I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf.

sorry bison*

[Mike Gilbert]

The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here.

[Alexis Menard (darktears)]

Created attachment 154637 [details]
Patch

[Alexis Menard (darktears)]

(In reply to comment #9)
> Created an attachment (id=154637) [details]
> Patch

Let's see EWS before asking for review. I'll give a shot on a Mac as EWS Mac is out of service for the moment.

[WebKit Review Bot]

Attachment 154637 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexis Menard (darktears)]

Created attachment 154643 [details]
Patch

[Alexis Menard (darktears)]

(In reply to comment #8)
> The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here.

That's what the last patch is addressing.

[WebKit Review Bot]

Attachment 154643 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mike Gilbert]

Is someone going to commit this? :)

[Adam Barth]

Comment on attachment 154643 [details]
Patch

Ok

[WebKit Review Bot]

Comment on attachment 154643 [details]
Patch

Clearing flags on attachment: 154643

Committed r124099: <http://trac.webkit.org/changeset/124099>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.