Bug 92659 - [css] Prefer usage of RenderStyle::textDecorationsInEffect() when rendering
Summary: [css] Prefer usage of RenderStyle::textDecorationsInEffect() when rendering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on: 93863
Blocks: 58491
  Show dependency treegraph
 
Reported: 2012-07-30 10:45 PDT by Bruno Abinader (history only)
Modified: 2012-08-13 10:19 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.07 KB, patch)
2012-07-30 10:50 PDT, Bruno Abinader (history only)
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 (1.03 MB, application/zip)
2012-07-30 12:17 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2012-07-30 10:45:50 PDT
WebKit currently has a proprietary CSS property '-webkit-text-decorations-in-effect', which as far as I've studied on the code and tested, is only used internally as part of the 'text-decoration' CSS property implementation (as up to CSS spec 2.1). Inside WebCore/rendering, there are mixed usage of both RenderStyle::textDecoration() and RenderStyle::textDecorationsInEffect(). To avoid a possible breach in terms of data redundancy, prefer usage of RenderStyle::textDecorationsInEffect() sounds more correct, after render style adjustments.
Comment 1 Bruno Abinader (history only) 2012-07-30 10:50:59 PDT
Created attachment 155322 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-30 12:17:10 PDT
Comment on attachment 155322 [details]
Patch

Attachment 155322 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13386544

New failing tests:
fast/css/first-line-text-decoration-inherited-from-parent.html
fast/selectors/visited-descendant.html
svg/text/text-deco-01-b.svg
svg/batik/text/textDecoration2.svg
css1/basic/inheritance.html
fast/ruby/text-decoration-in-descendants-ruby.html
svg/W3C-SVG-1.1/text-deco-01-b.svg
svg/batik/text/textDecoration.svg
fast/css/child-style-can-override-visited-style.html
css2.1/20110323/c543-txt-decor-000.html
Comment 3 WebKit Review Bot 2012-07-30 12:17:14 PDT
Created attachment 155335 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Bruno Abinader (history only) 2012-07-30 18:07:18 PDT
Comment on attachment 155322 [details]
Patch

Hmm, seems that I completely misunderstoond the concept here, thus I haven't attached this part of the patch into bug 90959... removing review request.
Comment 5 Bruno Abinader (history only) 2012-07-31 19:17:21 PDT
Actually not quite fully invalid :) I just found a breach while implementing patch for -webkit-text-decoration-color (bug 91638) where textDecorationsInEffect() is saner than textDecoration() usage: inside RenderObject::getTextDecorationColors, where colors for underline, overline and linethrough are obtained. However, there is no sense in having a separate patch for this change, which makes more sense to be part of that patch.