Bug 92611 - Prohibit having AuthorShadowDOM of input or textarea for a while and have a flag to enable it in Internals.
Summary: Prohibit having AuthorShadowDOM of input or textarea for a while and have a f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 82313
  Show dependency treegraph
 
Reported: 2012-07-29 21:52 PDT by Shinya Kawanaka
Modified: 2012-07-30 08:16 PDT (History)
11 users (show)

See Also:


Attachments
Patch (12.23 KB, patch)
2012-07-29 23:04 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2012-07-29 23:58 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (13.57 KB, patch)
2012-07-30 00:11 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (14.98 KB, patch)
2012-07-30 00:51 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 (706.08 KB, application/zip)
2012-07-30 03:57 PDT, WebKit Review Bot
no flags Details
Patch for landing (16.68 KB, patch)
2012-07-30 04:30 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-07-29 21:52:52 PDT
Unfortunately when fixing bugs of replaced elements, a lot of crashes happens in input element.
The primary reason is that the element in input Shadow DOM assumes that when an input element has a renderer, the elements in Shadow DOM also have renderers.
This does not hold currently.

So we woud like to prohibit adding Author Shadow DOM to input again.
Also, we would like to introduce a flag to enable it for testing purpose. When we make input element AuthorShadowDOM-ready, let remove this restriction.
Comment 1 Shinya Kawanaka 2012-07-29 23:04:52 PDT
Created attachment 155211 [details]
Patch
Comment 2 Early Warning System Bot 2012-07-29 23:17:09 PDT
Comment on attachment 155211 [details]
Patch

Attachment 155211 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13388333
Comment 3 Early Warning System Bot 2012-07-29 23:19:47 PDT
Comment on attachment 155211 [details]
Patch

Attachment 155211 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13385440
Comment 4 Shinya Kawanaka 2012-07-29 23:21:45 PDT
Actually we should disable AuthorShadowDOM for textarea also...
Comment 5 Build Bot 2012-07-29 23:29:43 PDT
Comment on attachment 155211 [details]
Patch

Attachment 155211 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13384483
Comment 6 Shinya Kawanaka 2012-07-29 23:58:03 PDT
Created attachment 155218 [details]
Patch
Comment 7 Shinya Kawanaka 2012-07-30 00:11:11 PDT
Created attachment 155221 [details]
Patch
Comment 8 Build Bot 2012-07-30 00:33:30 PDT
Comment on attachment 155221 [details]
Patch

Attachment 155221 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13391263
Comment 9 Shinya Kawanaka 2012-07-30 00:51:23 PDT
Created attachment 155226 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-30 03:57:14 PDT
Comment on attachment 155226 [details]
Patch

Attachment 155226 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13391316

New failing tests:
fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
Comment 11 WebKit Review Bot 2012-07-30 03:57:20 PDT
Created attachment 155248 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 12 Shinya Kawanaka 2012-07-30 04:30:54 PDT
Created attachment 155254 [details]
Patch for landing
Comment 13 WebKit Review Bot 2012-07-30 08:16:41 PDT
Comment on attachment 155254 [details]
Patch for landing

Clearing flags on attachment: 155254

Committed r124027: <http://trac.webkit.org/changeset/124027>
Comment 14 WebKit Review Bot 2012-07-30 08:16:46 PDT
All reviewed patches have been landed.  Closing bug.