Bug 92507 - [EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
Summary: [EFL] Regression(r123858): Default navigation policy decision was switched to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 92466
  Show dependency tree / graph
 
Reported: 2012-07-27 07:52 PDT by Chris Dumez
Modified: 2012-07-27 10:34 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2012-07-27 07:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-27 07:52:07 PDT 
http://trac.webkit.org/changeset/123858 changed the return values of a few functions, one of them being ewk_view_navigation_policy_decision().

The function used to return true (request is accepted) when the client does not handle the decision, now it returns false (request is rejected).
Comment 1 Chris Dumez 2012-07-27 07:55:00 PDT 
Created attachment 154952 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-07-27 08:19:03 PDT 
LGTM. For the records: first regression caught on the bots by the API unit tests.
Comment 3 Chris Dumez 2012-07-27 08:20:38 PDT 
(In reply to comment #2)
> LGTM. For the records: first regression caught on the bots by the API unit tests.

Yay! :)
Comment 4 Kentaro Hara 2012-07-27 08:44:21 PDT 
Comment on attachment 154952 [details]
Patch

OK
Comment 5 WebKit Review Bot 2012-07-27 10:34:44 PDT 
Comment on attachment 154952 [details]
Patch

Clearing flags on attachment: 154952

Committed r123883: <http://trac.webkit.org/changeset/123883>
Comment 6 WebKit Review Bot 2012-07-27 10:34:50 PDT 
All reviewed patches have been landed.  Closing bug.